#2696 Bug due to typo in upcoming.php 1.82.2.13

pending
None
5
2013-01-07
2012-10-16
Anonymous
No

upcoming.php v 1.82.2.13 dated 2011/04/27 - downloaded in the last week as part of v 1.25

Lines 214 and 215 wrongly have a capital "I" instead of a small i in getEndDateTImeTS

./upcoming.php:214: echo '<abbr class="dtend" title="'. export_ts_utc_date ($e->getEndDateTImeTS () )
./upcoming.php:215: . '">' . $e->getEndDateTImeTS () . "</abbr>\n";

Discussion

  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2012-10-16

    !! Addendum - there are actually 4 lines affected:

    ./upcoming.php:212: echo '<abbr class="dtstart" title="'. export_ts_utc_date ($e->getDateTImeTS () )
    ./upcoming.php:213: .'">' . $e->getDateTIme () . "</abbr>\n";
    ./upcoming.php:214: echo '<abbr class="dtend" title="'. export_ts_utc_date ($e->getEndDateTImeTS () )
    ./upcoming.php:215: . '">' . $e->getEndDateTImeTS () . "</abbr>\n";

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2012-10-16

    There are actually 4 lines affected

    ./upcoming.php:212: echo '<abbr class="dtstart" title="'. export_ts_utc_date ($e->getDateTImeTS () )
    ./upcoming.php:213: .'">' . $e->getDateTIme () . "</abbr>\n";
    ./upcoming.php:214: echo '<abbr class="dtend" title="'. export_ts_utc_date ($e->getEndDateTImeTS () )
    ./upcoming.php:215: . '">' . $e->getEndDateTImeTS () . "</abbr>\n";

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2012-10-17

    Also 4 more typos in these files - I corrected mine and my end day of untimed recurring events calculates correctly now. i.e. Fri-Sat-Sun event was showing up as Fri-Sat only with the end date being calculated as 5am Sun. It now correctly shows up for the 3 days with the end date being calculated as Monday 12am (essentially Sunday 11:59pm)- the true and correct cut-off for an untimed event. :)
    The 4 instances of getDatetime () here need to have the "t" in time capitalized as in getDateTime ()

    nb Anyone patching your own - do NOT change the variable which also appears below (begins with $) $getDatetime - that one is okay.

    ./includes/functions.php:3462: $popup_timestr = display_time ( $event->getDatetime () );
    ./includes/functions.php:3521: $getDatetime = $event->getDatetime ();
    ./upcoming.php:169: $timestr = display_time ( $e->getDatetime () );
    ./view_t.php:191: : ( ! $event->isUntimed () ? display_time ( $event->getDatetime () )

     
    Last edit: Anonymous 4 days ago
  • Craig Knudsen

    Craig Knudsen - 2013-01-07
    • assigned_to: nobody --> cknudsen
    • status: open --> pending
     
  • Craig Knudsen

    Craig Knudsen - 2013-01-07

    The code is now in the REL_1_2 branch and the main branch of
    CVS.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks