From: <ath...@us...> - 2014-03-27 13:39:57
|
Revision: 1589 http://sourceforge.net/p/webassembletool/code/1589 Author: athaveau Date: 2014-03-27 13:39:53 +0000 (Thu, 27 Mar 2014) Log Message: ----------- Checkstyle issues Modified Paths: -------------- trunk/esigate-core/src/main/java/org/esigate/Parameters.java trunk/esigate-core/src/main/java/org/esigate/cache/CacheAdapter.java trunk/esigate-core/src/main/java/org/esigate/extension/DefaultCharset.java trunk/esigate-core/src/main/java/org/esigate/extension/ExtensionFactory.java trunk/esigate-core/src/main/java/org/esigate/extension/monitoring/Metric.java Modified: trunk/esigate-core/src/main/java/org/esigate/Parameters.java =================================================================== --- trunk/esigate-core/src/main/java/org/esigate/Parameters.java 2014-03-27 13:25:10 UTC (rev 1588) +++ trunk/esigate-core/src/main/java/org/esigate/Parameters.java 2014-03-27 13:39:53 UTC (rev 1589) @@ -65,7 +65,8 @@ public static final Parameter<String> COOKIE_MANAGER = new ParameterString("cookieManager", DefaultCookieManager.class.getName()); public static final Parameter<Collection<String>> DISCARD_COOKIES = new ParameterCollection("discardCookies"); - public static final Parameter<Collection<String>> STORE_COOKIES_IN_SESSION = new ParameterCollection("storeCookiesInSession"); + public static final Parameter<Collection<String>> STORE_COOKIES_IN_SESSION + = new ParameterCollection("storeCookiesInSession"); public static final Parameter<String> FIX_MODE = new ParameterString("fixMode", "relative"); public static final Parameter<String> VISIBLE_URL_BASE = new ParameterString("visibleUrlBase"); // Possible values for remoteUrlBaseStrategy @@ -84,18 +85,21 @@ public static final Parameter<Boolean> USE_CACHE = new ParameterBoolean("useCache", true); public static final Parameter<Integer> MAX_CACHE_ENTRIES = new ParameterInteger("maxCacheEntries", 1000); public static final Parameter<Integer> MAX_OBJECT_SIZE = new ParameterInteger("maxObjectSize", 1000000); - public static final Parameter<String> CACHE_STORAGE = new ParameterString("cacheStorage", BasicCacheStorage.class.getName()); + public static final Parameter<String> CACHE_STORAGE + = new ParameterString("cacheStorage", BasicCacheStorage.class.getName()); public static final Parameter<Boolean> X_CACHE_HEADER = new ParameterBoolean("xCacheHeader", false); public static final Parameter<Boolean> VIA_HEADER = new ParameterBoolean("viaHeader", true); // Forced caching public static final Parameter<Integer> TTL = new ParameterInteger("ttl", 0); // Heuristic caching - public static final Parameter<Boolean> HEURISTIC_CACHING_ENABLED = new ParameterBoolean("heuristicCachingEnabled", true); + public static final Parameter<Boolean> HEURISTIC_CACHING_ENABLED + = new ParameterBoolean("heuristicCachingEnabled", true); // default value defined in // http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.2.4 public static final Parameter<Float> HEURISTIC_COEFFICIENT = new ParameterFloat("heuristicCoefficient", 0.1f); // when no cache directive at all, nothing is cached by default - public static final Parameter<Integer> HEURISTIC_DEFAULT_LIFETIME_SECS = new ParameterInteger("heuristicDefaultLifetimeSecs", 0); + public static final Parameter<Integer> HEURISTIC_DEFAULT_LIFETIME_SECS + = new ParameterInteger("heuristicDefaultLifetimeSecs", 0); // Background revalidation public static final Parameter<Integer> STALE_WHILE_REVALIDATE = new ParameterInteger("staleWhileRevalidate", 0); public static final Parameter<Integer> STALE_IF_ERROR = new ParameterInteger("staleIfError", 0); @@ -106,10 +110,13 @@ public static final Parameter<Integer> MAX_UPDATE_RETRIES = new ParameterInteger("maxUpdateRetries", 1); public static final Parameter<Integer> REVALIDATION_QUEUE_SIZE = new ParameterInteger("revalidationQueueSize", 100); // EhCache - public static final Parameter<String> EHCACHE_CACHE_NAME_PROPERTY = new ParameterString("ehcache.cacheName", "esigate"); - public static final Parameter<String> EHCACHE_CONFIGURATION_FILE_PROPERTY = new ParameterString("ehcache.configurationFile"); + public static final Parameter<String> EHCACHE_CACHE_NAME_PROPERTY + = new ParameterString("ehcache.cacheName", "esigate"); + public static final Parameter<String> EHCACHE_CONFIGURATION_FILE_PROPERTY + = new ParameterString("ehcache.configurationFile"); // MemCached - public static final Parameter<Collection<String>> MEMCACHED_SERVERS_PROPERTY = new ParameterCollection("memcached.servers"); + public static final Parameter<Collection<String>> MEMCACHED_SERVERS_PROPERTY + = new ParameterCollection("memcached.servers"); // Default size for String or byte buffers used to manipulate html page contents public static final int DEFAULT_BUFFER_SIZE = 1024; // Default size for String or byte buffers used to manipulate small things like tags, cookie, log lines Modified: trunk/esigate-core/src/main/java/org/esigate/cache/CacheAdapter.java =================================================================== --- trunk/esigate-core/src/main/java/org/esigate/cache/CacheAdapter.java 2014-03-27 13:25:10 UTC (rev 1588) +++ trunk/esigate-core/src/main/java/org/esigate/cache/CacheAdapter.java 2014-03-27 13:39:53 UTC (rev 1589) @@ -50,6 +50,10 @@ private boolean xCacheHeader; private boolean viaHeader; + /** + * Inititalize the instance + * @param properties properties + */ public void init(Properties properties) { staleIfError = Parameters.STALE_IF_ERROR.getValue(properties); staleWhileRevalidate = Parameters.STALE_WHILE_REVALIDATE.getValue(properties); Modified: trunk/esigate-core/src/main/java/org/esigate/extension/DefaultCharset.java =================================================================== --- trunk/esigate-core/src/main/java/org/esigate/extension/DefaultCharset.java 2014-03-27 13:25:10 UTC (rev 1588) +++ trunk/esigate-core/src/main/java/org/esigate/extension/DefaultCharset.java 2014-03-27 13:39:53 UTC (rev 1589) @@ -43,7 +43,7 @@ */ public class DefaultCharset implements Extension, IEventListener { private static final Logger LOG = LoggerFactory.getLogger(DefaultCharset.class); - + /** default charset */ public static final Parameter<String> PARAM_DEFAULT_CHARSET = new ParameterString("defaultCharset", "ISO-8859-1"); private Collection<String> parsableContentTypes; Modified: trunk/esigate-core/src/main/java/org/esigate/extension/ExtensionFactory.java =================================================================== --- trunk/esigate-core/src/main/java/org/esigate/extension/ExtensionFactory.java 2014-03-27 13:25:10 UTC (rev 1588) +++ trunk/esigate-core/src/main/java/org/esigate/extension/ExtensionFactory.java 2014-03-27 13:39:53 UTC (rev 1589) @@ -43,9 +43,9 @@ /** * Get an extension as configured in properties. * - * @param properties - * @param parameter - * @param d + * @param properties properties + * @param parameter the class name parameter + * @param d driver * * @param <T> * class which extends Extension class which extends Extension @@ -81,7 +81,8 @@ * @param d * @return the extension list */ - public static <T extends Extension> List<T> getExtensions(Properties properties, Parameter<Collection<String>> parameter, Driver d) { + public static <T extends Extension> List<T> getExtensions(Properties properties, + Parameter<Collection<String>> parameter, Driver d) { Collection<String> className = parameter.getValue(properties); List<T> finalResult = new ArrayList<T>(); for (String cName : className) { Modified: trunk/esigate-core/src/main/java/org/esigate/extension/monitoring/Metric.java =================================================================== --- trunk/esigate-core/src/main/java/org/esigate/extension/monitoring/Metric.java 2014-03-27 13:25:10 UTC (rev 1588) +++ trunk/esigate-core/src/main/java/org/esigate/extension/monitoring/Metric.java 2014-03-27 13:39:53 UTC (rev 1589) @@ -56,12 +56,12 @@ private Driver driver; @Override - public void init(Driver driver, Properties properties) { + public void init(Driver d, Properties properties) { LOG.debug("Initialize Metric"); driver.getEventManager().register(EventManager.EVENT_PROXY_POST, this); driver.getEventManager().register(EventManager.EVENT_FETCH_POST, this); - this.driver = driver; + this.driver = d; reporter = Slf4jReporter .forRegistry(this.metric) This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |