#5598 Timed Sign Out Still Allows Terminal Input / Changes?

[Jake Spires]

Hi Guys,
I can't tell you how much I love this tool :)

However - in this version when using the option to sign out idle session in the Browser (tested with MS Edge Version 108.0.1462.46 (Official build) (64-bit)
It is possible to hit the X in the session log out box over layed, which then closes and allows entry in the open Terminal window underneath.

[Ilia]

Hello,

This is expected as socket connection technically is a separate session. I am not sure if we should do it.

Jamie, what do you think, should we disconnect Terminal if parent session was closed?

[Jamie Cameron]

Wait the terminal is still active even if the user logs out? A logout should refresh the whole page, which will break the browser connection and close the terminal session..

[Ilia]

Wait the terminal is still active even if the user logs out?

Yes, of course.

A logout should refresh the whole page, which will break the browser connection and close the terminal session..

A user may have two tabs opened and logging out in one would still keep the page intact in the other.

The best would be is to check if parent session is actually active in utf8 => sub { } inside of shell server? Although, it seems to be a tricky part?

[Jamie Cameron]

Good point about tabs. We really do need to check the session inside the shell server then, because it's a risk if a user thinks they have logged out but didn't really..

[Jake Spires]

Need a screen recording?

[Ilia]

Yes, but only if we interpreted your problem incorrectly.

[Jake Spires]

Close - but I think a video will clear it up.

I will do one as soon as I can.

From: bugs@webadmin.p.re.sourceforge.net bugs@webadmin.p.re.sourceforge.net On Behalf Of Ilia
Sent: 14 December 2022 09:05
To: [webadmin:bugs] 5598@bugs.webadmin.p.re.sourceforge.net
Subject: [webadmin:bugs] Re: #5598 Timed Sign Out Still Allows Terminal Input / Changes?

Yes, but only if we interpreted your problem incorrectly.

---

[bugs:#5598]https://sourceforge.net/p/webadmin/bugs/5598/ Timed Sign Out Still Allows Terminal Input / Changes?

Status: open
Group: 2.010
Created: Tue Dec 13, 2022 03:10 PM UTC by Jake Spires
Last Updated: Tue Dec 13, 2022 07:02 PM UTC
Owner: nobody

Hi Guys,
I can't tell you how much I love this tool :)

However - in this version when using the option to sign out idle session in the Browser (tested with MS Edge Version 108.0.1462.46 (Official build) (64-bit)
It is possible to hit the X in the session log out box over layed, which then closes and allows entry in the open Terminal window underneath.

---

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/webadmin/bugs/5598/

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

The information contained in this e-mail (including attachments) may be confidential and is intended for the addressee only. Any unauthorised use, dissemination of the information, forwarding, copying or printing of the email is prohibited. If you are not the addressee please notify the sender immediately by return e-mail and delete the message. Although the e-mail and attachments are believed to be free of any virus, or any other defect which might affect any computer or system into which they are received or opened, it is the responsibility of the recipient to ensure that they are virus free and no responsibility is accepted by the sender for any loss or damage from receipt or use thereof.

[Jake Spires]

Hi Guys - Sorry this is difficult to screen record.
So a reproducible set.

Set Webmin so that it automatically logs off an unused session.

Log in fresh with one tab Edge Browser (version above)

In an active session open the Terminal Window

Wait for the session to reach the time out limit.

Webmin will overlay and a Window asking the user for login will obscure the terminal

You can enter your username / pwd / 2FA at this Windows or log in as intended.

BUG = Hit the cross in the corner of the Login Window to close the overlay, the overlay closes and you are able to enter commands in the terminal and the server responds.
BUG = Session time out, overlay can be closed and session still interactive.

Hope this is clear.

Regards

Jake

[Ilia]

Thanks, Jake. We will look into fixing it..

[Jake Spires]

That would be great thanks

I’ve been using Webmin or a LONG time now – nice to be able to help.
I will post all bugs I find 😊

Cheers

From: bugs@webadmin.p.re.sourceforge.net bugs@webadmin.p.re.sourceforge.net On Behalf Of Ilia
Sent: 14 December 2022 10:32
To: [webadmin:bugs] 5598@bugs.webadmin.p.re.sourceforge.net
Subject: [webadmin:bugs] Re: #5598 Timed Sign Out Still Allows Terminal Input / Changes?

Thanks, Jake. We will look into fixing it..

---

[bugs:#5598]https://sourceforge.net/p/webadmin/bugs/5598/ Timed Sign Out Still Allows Terminal Input / Changes?

Status: open
Group: 2.010
Created: Tue Dec 13, 2022 03:10 PM UTC by Jake Spires
Last Updated: Wed Dec 14, 2022 10:06 AM UTC
Owner: nobody

Hi Guys,
I can't tell you how much I love this tool :)

However - in this version when using the option to sign out idle session in the Browser (tested with MS Edge Version 108.0.1462.46 (Official build) (64-bit)
It is possible to hit the X in the session log out box over layed, which then closes and allows entry in the open Terminal window underneath.

---

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/webadmin/bugs/5598/

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

The information contained in this e-mail (including attachments) may be confidential and is intended for the addressee only. Any unauthorised use, dissemination of the information, forwarding, copying or printing of the email is prohibited. If you are not the addressee please notify the sender immediately by return e-mail and delete the message. Although the e-mail and attachments are believed to be free of any virus, or any other defect which might affect any computer or system into which they are received or opened, it is the responsibility of the recipient to ensure that they are virus free and no responsibility is accepted by the sender for any loss or damage from receipt or use thereof.

[Jamie Cameron]

I've implemented a nice simple fix for this issue at https://github.com/webmin/webmin/commit/726d28d80754d552021505e546dbf745015e61b6 . Terminal sessions will now be closed after at most 10 seconds after logout..