#5491 Solaris: Error "`verleneach=$' unexpected" when executing postinstall script

[Joes Garage]

On a Solaris system the package installation fails partially due to some error in the postinstall script:

Executing postinstall script.

Executing postinstall script ..
./setup.sh: syntax error at line 32: `verleneach=$' unexpected
pkgadd: ERROR: postinstall script did not complete successfully

Installation of <wswebmin> partially failed.</wswebmin>

[Ilia]

What Solaris version is that?

[Jamie Cameron]

Looks like this came from https://github.com/webmin/webmin/commit/23e7e1975cd2f8823a8a272e9226131aaa004209#diff-4209d788ad32c40cbda3c66b3de47eefb929308ca703bb77a6382625986add17

Ilia, I think we should undo that commit ... it uses shell features that aren't always available, and it's not worth breaking the install just to improve the formatting.

[Joes Garage]

Solaris 8 7/01, - to be frank ;-)

[Ilia]

Ilia, I think we should undo that commit ... it uses shell features that aren't always available, and it's not worth breaking the install just to improve the formatting.

I could do it. Although, perhaps it would be better to avoid using new shell features selectively?

[Jamie Cameron]

Since we have to support non-Linux distros that may be using non-bash shells, it's best to use only only classic /bin/sh features.

[Ilia]

Joes, could you try this patch and see if it works for you?

[Joes Garage]

Hi Ilia, as setup.sh is part of the postinstall routine I do not see a (simple) way to test that script standalone. I have the same opion as Jamie: please keep scripts compatible to any Unix/Linux distro by sticking to /bin/sh features.

[Ilia]

Alright, as Jamie advised to remove my initial commit to make it compatible with all shells, I have done so and simply removed wrapping * to make sure things don't look broken when upgrading using update script.