#5134 PoPToP not start/stop pptpd

[Sandro Santos]

On 1.881v, in "PPTP VPN Server", "Apply Configuration" and "Start/Stop PPTP Server" buttons are not working.

Ubuntu 17.04 server (VPS)
PoPToP version 1.4.0
pptpd v1.4.0

Full path to PPTP daemon program = /usr/sbin/pptpd
PPTP configuration file = /etc/pptpd.conf
Full path to PPTP PID file = /var/run/pptpd.pid
PPP accounts file = /etc/ppp/chap-secrets
Default PPP options file = /etc/ppp/options
PPTP PPP options file = /etc/ppp/pptpd-options
Command to start PPTP daemon = /etc/init.d/pptpd start
Command to stop PPTP daemon = /etc/init.d/pptpd stop
File to which PPP messages are logged = /var/log/messages

[Sandro Santos]

Hi, I do not know if it is the most correct way, but since I needed a solution and did not find anything about it, I adapted the code snippet to the "Apply configuration" button from the file "\net\index.cgi" to the buttons of the "/pptp-server/index.cgi" file and it worked:

if ($access{'apply'}) {
    if ($pid && kill(0, $pid)) {
        print &ui_buttons_start();
        print &ui_buttons_row("apply.cgi", $text{'index_apply'},
                              $text{'index_applydesc'});
        print &ui_buttons_end();
#       print "<form action=apply.cgi>\n";
#       print "<tr> <td><input type=submit ",
#             "value='$text{'index_apply'}'></td>\n";
#       print "<td>$text{'index_applydesc'}</td></tr></form>\n";
        if ($access{'stop'}) {
                print &ui_buttons_start();
                print &ui_buttons_row("stop.cgi", $text{'index_stop'},
                                      $text{'index_stopdesc'});
                print &ui_buttons_end();
#               print "<form action=stop.cgi>\n";
#               print "<tr> <td><input type=submit ",
#                     "value='$text{'index_stop'}'></td>\n";
#               print "<td>$text{'index_stopdesc'}</td></tr></form>\n";
                }
        }
    else {
        print &ui_buttons_start();
        print &ui_buttons_row("start.cgi", $text{'index_start'},
                              $text{'index_startdesc'});
        print &ui_buttons_end();
#       print "<form action=start.cgi>\n";
#       print "<tr> <td><input type=submit ",
#             "value='$text{'index_start'}'></td>\n";
#       print "<td>$text{'index_startdesc'}</td></tr></form>\n";
        }
    }
}

[Jamie Cameron]

Thanks for pointing this out - I'll include a similar fix in the next release.