Menu

#5049 Unused, unset variables in setup.sh

1.860
closed-fixed
nobody
setup (1)
1
2017-12-07
2017-12-06
H J Wolfson
No

Hi,
I hesitate to call this a bug, and I apologise if I'm missing something obvious, here. However,
while reading through the install script for webmin-1.860, in order to produce a setup-pre.sh to automate installation on my VoidLinux machines, I noticed two variables ($ppath and $listen) echoed to miniserv.conf that don't get set anywhere else in the script (so $listen always gets set to the default, 10000). Since $ppath stays empty and $listen, when commented out, doesn't appear to affect anything (while $port does), could they be removed?
Thanks,
Wolfson

Discussion

  • Jamie Cameron

    Jamie Cameron - 2017-12-07
    • status: open --> closed-fixed
     
  • Jamie Cameron

    Jamie Cameron - 2017-12-07

    For $listen, this is intentional - it can be set by other scripts that call setup.sh to force use of a custom port. $ppath is useless though, so I'll remove it.

     

Log in to post a comment.