#5011 Existing username or groupname in quotation marks gets removed when selecting and adding new members to Valid users option

[srikar]

Hi. I installed Webmin 1.850 on Ubuntu 16.04 system . Currently using Webmin on Firefox 54.0.1 browser. I have an issue with usernames and groupnames present in quotation marks. Whenever I tried to select and add users to Valid users option present in Samba Windows File Sharing, already exiting users which are present in quotes are removed from the list.

For example consider the Valid user looks like this:
Valid users = "SAMDOM\domain person", SAMDOM\demouser1
Now if I select and add new user by name "SAMDOM\demouser2" then Valid users looks like below:
Valid users = SAMDOM\demouser2
Previous users are getting erased and replaced with new user.

Now let us consider another example where Valid users looks like this:
Valid users = SAMDOM\"domain person", SAMDOM\demouser1
Now if I select "SAMDOM\demouser2" again and add it to Valid users option it looks like below:
Valid users = SAMDOM\ , SAMDOM\demouser2

Based on the above two examples it can be seen that whenever there is a username with quotes, whatever the users staring after that quotes are also getting removed from the Valid users option. Same issue is observed for Valid groups option too. Please look into this. Thanks in Advance.
Regards,
S.Srikar

[Jamie Cameron]

Thanks for pointing this out - this will be fixed in the next Webmin release.

[srikar]

Hi Jamie.Thanks for looking into it. I have made changes to the user_chooser and group_chooser cgi files according to the commit you have done for this bug and tested . The issue still exists.
Note:user_chooser and group_chooser cgi files also contain changes done for bug 5007.