#4998 DHCP configuration "removes" quotations

[Marek]

Hi.
The GUI DHCP Server confguration tool, removes the quotation marks for DHCP custom option in the dhcpd.conf file. After it, the DHCP service crashed down during restart.

I added the line:
option option-132-VLAN-ID code 132 = text;
option option-132-VLAN-ID "91";
to the file but, when I'have do some other changes using GUI, the Webmin saves the line as:
option option-132-VLAN-ID 91;
Without quotation marks sorrounding value 91. I have to change it manualy and since this, I can start service correctly.

[Jamie Cameron]

Ok ... I guess this is because the VLAN-ID custom option is defined as "text" type?

[Marek]

Hi. The custom option has been definied as "text" and, as the page https://linux.die.net/man/5/dhcpd-options can help, the "text" option "...must be enclosed in double quotes" but currently usinf Webmin, doesn't.
Thanks for any help.
Marek

[Jamie Cameron]

Thanks - Webmin is handling the "string" option type correctly, but not "text". I will fix this in the next release.