Invalid javascript in ui-lib.pl with v1.850

A web-based interface for system administration of UNIX

Brought to you by: iliaross, jcameron

#4982 Invalid javascript in ui-lib.pl with v1.850

Milestone: 1.850

Status: closed-fixed

Owner: nobody

Labels: None

Priority: 5

Updated: 2017-07-10

Created: 2017-06-29

Creator: Zachariah Thomas

Private: No

The javascript around openerobj.innerHTML seems to be incorrect.

Discussion

Jamie Cameron - 2017-06-30

How is it invalid exactly?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Zachariah Thomas - 2017-06-30

Sorry if this is too brief, I'm on a mobile device.
The syntax errors might been introduced with commit: 7e75fdfa1644dc0cf8a7a5f62a15511e17a6fe8c

Basicallly single quotes were added, which end the javascript string literals too soon.
E.G. '... src=$...' was altered to '... src='$...'...' instead of "... src='$...'..." or '... src=\'$...\'...'

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jamie Cameron - 2017-07-01

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jamie Cameron - 2017-07-01

Ok, I see what you mean - this will be fixed in the next release.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Richard Farthing - 2017-07-10

Thanks. FYI the ancient (but still useful) Eldy theme seems to be broken by this issue.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.