Menu
▾
▴
1 Attachments
#4872 Add primary partition link missing.
Trying to add a new primary partition but the "Add primary partition" link is missing. When I do a View Source, it's there but it appears that there is a missing ending paragraph tag and two starting paragraph tags.
This happens no matter what theme I am using.
Works for me. ... does your disk perhaps already have 4 primary partitions?
No sir, its a new disk that was installed. I use it for backup archive purposes so I have to partition it first then I mount it and use Bacula to copy full backups onto it. I've tried chrome, IE and Firefox and tried 2 different computers with different themes running on Webmin. Just rebooted the server to see if something was up there and no go.
This works fine on my Webmin 1.830 test systems. Which browser are you using there?
IE, Firefox and Chrome all do the same. I did notice I'm running 1.831 though. Maybe I need to go back to 1.830 (if I can figure out how).
Running CentOS Linux 7.3.1611 and did a Yum remove webmin and yum install webmin but that didn't help. Must just be my system if it's working on yours.
I just found the BWTheme for Webmin, installed it and now I have the Add Partition link so it must be something with the Authentic Theme 18.32. I though it didn't work in the Grey Framed Theme but it does not too. Thanks for your quick response!
Can you attach a screenshot of the problem on your system?
PDF attached on original post that shows it missing and the HTML code with no closing
tag before the link. I would suspect this is causing the issue.It shows
The
tag seems very very unlikely to cause this, since it is frequently used by itself in Webmin as a spacer.
If you inspect the DOM of the page in chrome, can you see that link?
I just installed webmin 1.881 and stumbled over the same problem. changed default "Authentic theme" to "old webmin theme" (gosh, is that ugly) and the link is there. Changed to 'gray framed theme' and the link also is there. Changed back to authentic, and the link is missing"
Do you see the button, with plus sign at the top right of the table header?
Now that you mention it - Yes, I do. And hiding behind it is - WOW, the missing link! Maybe too much hiding is not a good thing?
P.S. using Webmin for the second day now on my first server; I am mightily impressed!
Thank you.
It's debatable of how interface controlls should be displayed. It's a very thin line there. It's difficult to make thing beautiful and usable at the same time. In my oppinion, once it's visible and it's at the top of the table header - there is nothing more explicit.
I agree that it could be more contrast and I'm gonna add contrast mod for the theme.
Let me ask you something - when using Google material design sites, you could have "add button", floating somewhere at the bottom-right of the screen. Can you always find it quickly? I didn't at first but now it's very intuitive.
I dont know. What's your offer? Bring back ugly link, just being placed over the table?
Well, now I'm thinking that replacing existing add button in table top-right header to something that uses Google in its material design is going to be better recognizeable.
Better recognizable, yes. But I don't think it addresses the issue of intuitiveness and consistency. You have come a long way from the earlier designs to the Authentic one, and it is already remakable that you can unite so many modules in a more or less consistent way. Authentic looks good, handles well. But here are my 5 cents:
Looking at Hardware -> Partitions on Local Disks -> clicking on one disk name, you get a page with headline "Edit Disk Partitions". There I find 2 buttons (Edit.., Wipe..) Why then is the (arguably) more important task of edit disk partitions relegated to yet another variant of a button in the upper right corner? In this place I would expect to find more editorial content (color, size, layout, config the page,...) then a key task. Why not put the +-button content into a 3rd button? (And make them the same size for beauty.)
Going back one page to the disk list: there are the Actions as green and orange filled boxes. So on these two pages you have 3 different ways of giving commands. Can't you choose one method only? (I find the green and orange backgound pleasing to the eye.)
One more observation: almost all (or all?) buttons are greyed out until you put your mouse pointer over it. This is the opposite of the ususal experience, which is that something that is greyed out is only currently not available. I would always leave the bottons in the 'active' color status, unless they are truly not possible to be selected in this moment.
This would apply also to e.g. the Webmin Configuration page, which looks a bit dull in all its grey, while the icons are actually very nice, pleasingly colored. You indicate that a mouse pointer is over an icon with it becoming colored and shifted a little bit. One of them (my choice: shifting) should be enough (or perhaps becoming a colored frame).
Keep up the good work - now that I know how harddisks are being handled, I find it even easier to use Webmin than use the desktop ;-)
Oh, I start to agree more with you on that and dislike the fact that the button is so separated from the module's body.
Because it would require specific patch for each module. This behaviur (moving add button to the top right of the table), is an abstraction of used logic accross many modules.
It was just a link in the past. Now it has to be more than that - it has to look good as well.
You can disable this in Theme Configuration/Table options - Grayscale table icons and bring color on focus only.
Not sure what you mean. Screenshot is always welcomed.
Did that and it's looking great! It is 'only' the look, but surely worth being the default. Compliment to the icon artist.
Yes, herding that many modules is an issue. But why do you then have these two link buttons, and not also relocate them into the +-icon?
The third variant of buttons, the green and orange filles boxes refers to this page: (Don't know how to add an image; put it as attachment)
Again, I think elements shouldn't be gread-out when they are active. The +-button would become more visible. And some color to it wouldn't hurt. You had mentioned the Google +-button (alwys bright blue?) yourself.
Honestly, I disagree. :) I like colors being shown on hover only. It's been like this for years already.
I just think maybe we should try with floating + button, like google does. It symbolizes new stuff, thus maybe having it placed aside (not table header), should be good.
I'll think about it. Meanwhile, theme has extensions and you can easily make own patch, that would survive updates and make things displayed as you wish.
Again, when there are too many buttons, it's very annoying to have them all colored and displayed at once. You see the buttons, when you hover the row they become colored and this visual effect also helps user to make sure that the right row is selected.
:) can't argue about taste. Perhaps another taste issue, but I think that your icons exhibit 'restraint' coloring, while the Google material stuff has very bold, glaring coloring. I think the two won't go together well?
But one thing remains true: you are using two options (greyed-out and color) for one state, i.e. an active button. This deprives you of one of the few options to signal to the user. You could use greyed-out for inactive options, missing options, not-installed options, currently not usable (like formatting a disk taht has no partition), and more.
It's been fixed with the latest commit:
https://github.com/qooob/authentic-theme/commit/b732e4fecc0a442be527e67742b1aacc33a44f14
Force update the theme to the latest dev version, to see the difference.
Yes, a prominent button above and below the listing of partitions - even newcomer like me won't miss that anymore ;-).
Looks like you overcame your aversion to another button by somehow integrating it into the html table style? Looks nicer than the other two buttons.
I took another old cluncker of a disk and tried it out. Some more issues came up, which I'll put to the https://sourceforge.net/p/webadmin/bugs/5113/ post. What is perhaps relevant here is that the issue is: after creating 4 partitions to fill the 4 slots of a MSDOS-Partition-table the button allowed me to attempt to create a 5th partition. (see attachment). Of course this fails for 2 reasons: no cylinders left, and even if there were, the partition-table has no 5th entry.
So, here a greyed-out, i.e. inactive button should be.
Of course, there are more partition-table types than just MS-DOS, and it may not be justified to mimic gparted in a web interface? But then the limits of this webmin tool should be explained (in a help link perhaps).
What do you mean?
This looks like module logic issue, not the theme.
Like in the attachment. The new button looks like being part of the table. The other two buttons 'Edit IDE Paramaters' and 'Wipe ...' are a different breed
Yes, except for the greyed-out part to signal inactive.
Yes, showing the link to add a new primary partition when there is no space for a new one is a webmin bug.