#4773 No bookmarks filemin after reload

[Hubert Zweckstetter]

I have restricted accounts in Webmin 1.801 that don't exist in the system.
Access in filemin is set to a existing user, but the bookmarks in ~/.filemin/.bookmarks
are not rendered in the HTML.

Seems to me that get_bookmarks in filemin/filemin-lib.pl does not set remote_user_info correct.
The patch in the attachement fixed it for me.

It would be nice, if the filemin settings would not be on system user base ($HOME) but on webmin user base, eg. stored for excample in /var/webmin/<user>, as two webmin users sharing the same system user can overwrite each others settings.</user>

[Jamie Cameron]

Thanks for the patch, but isn't that same code already in the get_paths function?

[Hubert Zweckstetter]

Yes the code is copied from there.
It looks like get_paths is not called prior to get_bookmarks.
I'm using the authentic theme. Perhaps the problem lies there.

[Jamie Cameron]

But the only call to get_bookmarks is in print_interface() and all the scripts that call this function first calll get_paths

[Hubert Zweckstetter]

thats right, but
local @remote_user_info = getpwnam($remote_user);
in print_interface() does not get the remote user structure because remote_user is no system user, only a webmin user with $access{'work_as_user'} or $access{'work_as_root'} set

[Jamie Cameron]

Try this patch : https://github.com/webmin/webmin/commit/8d6124321f2eccace52add5cb29dad8feb5b5a66

[Hubert Zweckstetter]

that works for me in authentic theme when I apply the change of
https://github.com/qooob/authentic-theme/issues/490

in "Grey Framed Theme" I get "The Unix user ... does not exist"

[Hubert Zweckstetter]

when I substitute switch_to_remote_user(); with &get_paths(); in filemin/bookmark.cgi line 8
the bookmark file is written in "Grey Framed Theme" too.
I don't know if this creates side effects, but its working for me.

[Jamie Cameron]

Thanks, I'll apply that fix