#4560 Perl-exec error upon user renaming

[Tomáš Novosad]

Hello,

i'v found a small typo that causes perl-exec error when renaming system user.

error goes like:

acl::useradmin_modify_user failed : Not a HASH reference at /usr/libexec/webmin/acl/acl-lib.pl line 1293

this is caused by typo in this piece of code

if ($miniserv{'session'} && $username ne $user->{'name'}) {
# Modify all sessions for the renamed user
&rename_session_user(\&miniserv, $username, $user->{'name'});
}

that is in file acl/acl-lib.pl at the end of function ''modify_user'' (line #740)

Problem is that first parameter to function call is passed as ''\&miniserv'' (ref to subroutine), whever there should be ''\%miniserv'' (ref to hash) - as called function expect the parameter to be miniserv config hash.

the code mentioned is executed by callbacks when renaming system user.

i'v seen this bug in 1.73 and 1.71.
Prevoius version i had no problem was 1.630

Thanks for help
Tomas Novosad

[Jamie Cameron]

Thanks for pointing this out - this will be fixed in the next release.

[Tomáš Novosad]

Oh,

thanks for quick reply.