#4081 /etc/fstab corrupt after adding mount

[Anonymous]

Reproduce steps:
- In the root fs ( / ) create a folder named "disks" and in that folder one named "2TB Disk 3"
- Add a new harddrive
- Create a partition on the drive
- Open D & nfs module
- Add mount of type Linux Native FS (ext3)
- Browse to the /disks/2TB Disk 3 folder and select Ok
- select partition sdd1 to be mounted on the selected path,
- Enable user and group quata for the mount and save the new mount.

Webmin doesn't check for the space in selected mount path and messes up /etc/fstab without any error message. After this procedure webmin has trouble managing the file any further, manualy removing the mounts from /etc/fstab fixes system problems though webmin seems to be unable to sync to the manual changes after the intervention. Restarting webmin did not help. the module is kind of gone nuts for me.

System details:
Centos 5.8
Webmin version 1.585

[Jamie Cameron]

Looks like there are some bugs in Webmin's handling of mount points with spaces in them - I will fix that in the next release. Removing the bad line from /etc/fstab should fix the issue though.

I'd recommend against using mounts like this anyway, as they are hard to navigate into from the command line, may export bugs in other tools, and break the format of files like /etc/mtab .

[Anonymous]

Using spaces in mounts is indeed a stupid idea, bad practice and ill advised.

I was in the assumption the folder had underscores in the name. using the virtualmin framed theme underscores are invisible. they seem to end up below the margins.

try creating a mail or server account and add an unserscore to the password. after that select the show password window. I cant see the _ in the password (at least on my machine W7 ulti / ie9 ) when you copy past the password the underscore is there only invisible hidden behind the bottom part of de box.

I have added a link to a snapshot. the password in this case ends with an _ though its not visible.

http://tinypic.com/view.php?pic=nd1t12&s=5

[Jamie Cameron]

Odd, I can see underscores just fine on my system. Which browser are you using, and on which OS?

[Gerard J. Cerchio]

This error seems to have come back using Webmin 1.941 on Raspbian Linux 10 Linux 4.19.97-v7l+ on armv7l on a Pi 4. The mount point kept the space and Raspbian stop the boot dead in its tracks. I had to mount the disk on another machine and replace the space in the mount path with \040 to recover the system. I know should not have spaces in mount points, but there is a historical reason.

[Jamie Cameron]

Yeah, the /etc/fstab file format is not friendly to mount points with spaces in them at all.

[Gerard J. Cerchio]

I'm fine with webmin not dealing with space to \040 and visaversa in the mount path field, but some static text in the panel giving a warning about spaces is minimal work and would save users some non-boot problems.

[Jamie Cameron]

Thanks for the pointer about \040 - the next Webmin release will insert and remove this automatically when mount points have spaces.

[Gerard J. Cerchio]

Lovely! Thanks! Beware of spaces at the end of the path in the text field, they should simply be truncated.