#3547 save_fileset.cgi creates broken config.

1.490
closed-fixed
6
2009-11-29
2009-11-24
Caspar Smit
No

I can't seem to find the exact cause of this but..

This bug can be reproduced easily.

1) Select "File Sets" in the director configuration
2) Click "Add a new backup file set"
3) Fileset name: test fileset
Files and directories to backup: /test1
File signature type: none
Files and directories to skip: /test2

And click create
4) This creates the following in the config file (Which is perfectly OK):

FileSet {
Name = "test fileset"
Include {
File = /test1
Options {
}
}
Exclude {
File = /test2
}
}

5) Then EDITING this fileset creates the bug.
6) Click on the file set "Test fileset"
7) Add /test3 to the Files and directories to backup
8) Click save and the following error displays:

Error - Perl execution failed

Too many section ends at line 244 at ./bacula-backup-lib.pl line 102.

9) The resulting config file reads (Which is wrong, the is no exclude statement anymore, excluded directories are doubled, no proper closure of statements):

FileSet {
Name = "test fileset"
Include {
File = /test1
Options {
}
File = /test3
}
File = /test2
File = /test2
}
}

10) The resulting config SHOULD BE:

FileSet {
Name = "test fileset"
Include {
File = /test1
File = /test3
Options {
}
}
Exclude {
File = /test2
}
}

Discussion

  • Caspar Smit

    Caspar Smit - 2009-11-27

    Hi,

    This is a Serious bug and breaks the bacula backup system. I hope this can be fixed soon.

    Kind regards,
    Caspar Smit

     
  • Caspar Smit

    Caspar Smit - 2009-11-27
    • priority: 5 --> 6
     
  • Jamie Cameron

    Jamie Cameron - 2009-11-29

    This will be fixed in Webmin 1.500.

    Actually, the fix should already be in the 1.499 development version of Webmin, available from http://www.webmin.com/devel.html

     
  • Jamie Cameron

    Jamie Cameron - 2009-11-29
    • status: open --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks