Menu
▾
▴
#5 BatchClient needs refactored
CIMOMHandle contains a method declaration
performBatchOperations(BatchHandle) at a minimum I
think this should be pushed down to the CIMClient
class, but ideally I think it should be removed. I
don't think the API should force a coupling between the
standard client and the batch client. If the
implimentor wants to share part of the impl that should
be up to them.
The other thing that doesn't look right to me is that
the BatchHandle only has methods to queue operations,
but there isn't a way to get the list of queued
operations which the performBatchOperations() method
would need.
BatchResult allows access to the results, but only
exposes the results as Object. And the result and
failed/succes status are decoupled. It'd be nice if the
returned object was an OperationResult which contained
the status and the result object. Even nicer might be
subclasses that return explict objects like
InstanceOperationResult that contained a CIMInstance or
an IteratorOperationResult, etc...