Menu ▾ ▴

#217 Smaller CMake improvements

0.3.6
done
nobody
None
nobody
2023-12-30
2021-12-25
Ulf Lorenz
No

Assorted issues with the current CMake code:

  • use a Python venv + requirements.txt for all the Python parts (test + demos); maybe separate the Python interface and the library more strongly
  • maybe a build option to skip all Python plotting for fewer dependencies
  • make the Python unittests a dependency of CMake so that they are updated automatically
  • make the wp_build.sh script usable again. At least it needs to know the install paths
    • along the way, this may also obsolete [#186]
  • add all files to the project, including those that are not built: Python files, (internal) headers, docs, ...
  • maybe also add a step-by-step guide on how to set everything up with vcpkg, venvs etc.?
  • did not add a venv; for a library this seems like a too strange behavior. Instead, the user is now advised to set up a venv on his w=own with a given requirements.txt
  • did not implement the build option to skip the plotting. With the recommended venv, a few additional Python modules are not an issue at all, and plotting is important.
  • unittests are already a dependency; my fault to not use ctest --build-and-test
  • wp-build.sh works again
  • files are added to the Python target; not all seem to appear in all IDEs, though or so.

Related

Tickets: #186

Discussion

  • Ulf Lorenz

    Ulf Lorenz - 2021-12-28
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -2,3 +2,4 @@

 - use googletest provided by the system => add usage of vcpkg or pkgconfig-googletests
 - make the wp_build.sh script usable again. At least it needs to know the install paths
+    - along the way, this may also obsolete [#186]
     

    Related

    Tickets: #186

  • Ulf Lorenz

    Ulf Lorenz - 2022-10-03
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,5 +1,6 @@
 Assorted issues with the current CMake code:

 - use googletest provided by the system => add usage of vcpkg or pkgconfig-googletests
+- build option to skip all Python plotting for fewer dependencies
 - make the wp_build.sh script usable again. At least it needs to know the install paths
     - along the way, this may also obsolete [#186]
     

    Related

    Tickets: #186

  • Ulf Lorenz

    Ulf Lorenz - 2022-10-03
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -2,5 +2,6 @@

 - use googletest provided by the system => add usage of vcpkg or pkgconfig-googletests
 - build option to skip all Python plotting for fewer dependencies
+- make the Python unittests a dependency of CMake so that they are updated automatically
 - make the wp_build.sh script usable again. At least it needs to know the install paths
     - along the way, this may also obsolete [#186]
     

    Related

    Tickets: #186

  • Ulf Lorenz

    Ulf Lorenz - 2022-12-24
    • Milestone: 0.4 goal --> 0.3.6
     

  • Ulf Lorenz

    Ulf Lorenz - 2022-12-24
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -5,3 +5,4 @@
 - make the Python unittests a dependency of CMake so that they are updated automatically
 - make the wp_build.sh script usable again. At least it needs to know the install paths
     - along the way, this may also obsolete [#186]
+- add _all_ files to the project, including those that are not built: Python files, (internal) headers, docs, ...
     

    Related

    Tickets: #186

  • Ulf Lorenz

    Ulf Lorenz - 2023-04-07
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,6 @@
 Assorted issues with the current CMake code:

-- use googletest provided by the system => add usage of vcpkg or pkgconfig-googletests
+- use a Python venv for all the Python code; maybe separate the Python interface and the library more strongly
 - build option to skip all Python plotting for fewer dependencies
 - make the Python unittests a dependency of CMake so that they are updated automatically
 - make the wp_build.sh script usable again. At least it needs to know the install paths
     

  • Ulf Lorenz

    Ulf Lorenz - 2023-04-07
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,6 @@
 Assorted issues with the current CMake code:

-- use a Python venv for all the Python code; maybe separate the Python interface and the library more strongly
+- use a Python venv for all the Python parts (test + demos); maybe separate the Python interface and the library more strongly
 - build option to skip all Python plotting for fewer dependencies
 - make the Python unittests a dependency of CMake so that they are updated automatically
 - make the wp_build.sh script usable again. At least it needs to know the install paths
     

  • Ulf Lorenz

    Ulf Lorenz - 2023-12-04
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,8 +1,9 @@
 Assorted issues with the current CMake code:

-- use a Python venv for all the Python parts (test + demos); maybe separate the Python interface and the library more strongly
-- build option to skip all Python plotting for fewer dependencies
+- use a Python venv + requirements.txt for all the Python parts (test + demos); maybe separate the Python interface and the library more strongly
+- maybe a build option to skip all Python plotting for fewer dependencies
 - make the Python unittests a dependency of CMake so that they are updated automatically
 - make the wp_build.sh script usable again. At least it needs to know the install paths
     - along the way, this may also obsolete [#186]
 - add _all_ files to the project, including those that are not built: Python files, (internal) headers, docs, ...
+- maybe also add a step-by-step guide on how to set everything up with vcpkg, venvs etc.?
     

    Related

    Tickets: #186

  • Ulf Lorenz

    Ulf Lorenz - 2023-12-25
    • status: open --> assigned
    • assigned_to: Ulf Lorenz
     

  • Ulf Lorenz

    Ulf Lorenz - 2023-12-30
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -7,3 +7,11 @@
     - along the way, this may also obsolete [#186]
 - add _all_ files to the project, including those that are not built: Python files, (internal) headers, docs, ...
 - maybe also add a step-by-step guide on how to set everything up with vcpkg, venvs etc.?
+
+----
+
+- did not add a venv; for a library this seems like a too strange behavior. Instead, the user is now advised to set up a venv on his w=own with a given requirements.txt
+- did not implement the build option to skip the plotting. With the recommended venv, a few additional Python modules are not an issue at all, and plotting is important.
+- unittests are already a dependency; my fault to not use ctest --build-and-test
+- wp-build.sh works again
+- files are added to the Python target; not all seem to appear in all IDEs, though or so.
     

    Related

    Tickets: #186

  • Ulf Lorenz

    Ulf Lorenz - 2023-12-30
    • status: assigned --> done
    • assigned_to: Ulf Lorenz --> nobody
     

Log in to post a comment.