All import calls are triggering a ton of "Parsing Report" noise that should be associated to a verbosity flag.
Positive feedback:
- This new output has been vital for giving visibility on parsing errors, which otherwise can sneak into the ARFF files
Negative Feedback:
- When parsing thousands of CSV files (for instance) these parsing reports can be massive on the terminal, variable on the number of distinct attributes discovered
Thanks!
Todd
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
As a general bit of feedback here, the existing library needs to be altered around cout's a bit to be really integrated well into external systems using the CLI alone.
For instance, calling waffles_dimred attributeselector includes a comment in the header, while it is pretty helpful to pipe the output to a file and post-process to drive next set of CLI commands
It would be helpful to have a way to disable the 'informative' content to enable easier integration to other tooling.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
It sounds like you have good ideas, so I went ahead and gave you commit access to the repository, in case you don't want to wait for me to get to it. Here are some general guidelines about contributing to this project:
1- I believe in on-line training, so if you think something should be done, just go ahead and do it.
2- If you don't add unit tests (to waffles/src/test/main.cpp), don't be surprised when a well-intentioned commit breaks your feature.
3- Even unit tests do not guarantee your feature is permanent because I care more about moving forward than maintaining backward compatibility. If you really want to protect something, you are welcome to maintain a stable fork.
4- If you change a command-line tool, it would be good to update src/GClasses/usage.cpp.
5- Be aware that contributions fall under the license specified in the header.
6- Don't try to establish rules. I'm just having fun.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
SHA 6be55623e92fec4e7eaba3c8fba4ed8c0bbf9b9a
All import calls are triggering a ton of "Parsing Report" noise that should be associated to a verbosity flag.
Positive feedback:
- This new output has been vital for giving visibility on parsing errors, which otherwise can sneak into the ARFF files
Negative Feedback:
- When parsing thousands of CSV files (for instance) these parsing reports can be massive on the terminal, variable on the number of distinct attributes discovered
Thanks!
Todd
As a general bit of feedback here, the existing library needs to be altered around cout's a bit to be really integrated well into external systems using the CLI alone.
For instance, calling
waffles_dimred attributeselector
includes a comment in the header, while it is pretty helpful to pipe the output to a file and post-process to drive next set of CLI commandsIt would be helpful to have a way to disable the 'informative' content to enable easier integration to other tooling.
It sounds like you have good ideas, so I went ahead and gave you commit access to the repository, in case you don't want to wait for me to get to it. Here are some general guidelines about contributing to this project:
1- I believe in on-line training, so if you think something should be done, just go ahead and do it.
2- If you don't add unit tests (to waffles/src/test/main.cpp), don't be surprised when a well-intentioned commit breaks your feature.
3- Even unit tests do not guarantee your feature is permanent because I care more about moving forward than maintaining backward compatibility. If you really want to protect something, you are welcome to maintain a stable fork.
4- If you change a command-line tool, it would be good to update src/GClasses/usage.cpp.
5- Be aware that contributions fall under the license specified in the header.
6- Don't try to establish rules. I'm just having fun.