• Join/Login
  • Business Software
  • Open Source Software
  • For Vendors
  • Blog
  • About
  • More
    • Articles
    • Create
    • SourceForge Podcast
    • Site Documentation
    • Subscribe to our Newsletter
    • Support Request
SourceForge logo
For Vendors Help Create Join Login
SourceForge logo
SourceForge logo
Business Software
Open Source Software
SourceForge Podcast
Resources
  • Articles
  • Case Studies
  • Blog
Menu
  • Help
  • Create
  • Join
  • Login
  • Home
  • Browse
  • w3m
  • Patches

w3mimgdisplay needs -lX11 but imlib2-config no longer provides it

Brought to you by: a-ito, hsaka, inu, ukai
  • Summary
  • Files
  • Reviews
  • Support
  • Tickets ▾
    • Patches
    • Feature Requests
    • Support Requests
  • News
  • Discussion
  • Code
Menu ▾ ▴
  • Create Ticket
  • View Stats

Group

Searches

  • Changes
  • Closed Tickets
  • Open Tickets

Help

  • Formatting Help

#70 w3mimgdisplay needs -lX11 but imlib2-config no longer provides it

Unstable (example)
open
nobody
None
5
2014-01-31
2014-01-31
Hanspeter Niederstrasser
No

Up until imlib2-1.4.5, imlib2-config --libs published -lX11 and w3m used that to get the X11 library flags to finish linking. However, imlib2-config from imlib2-1.4.6 no longer publishes that flag:

$ imlib2-config --libs
-L/usr/really-local/lib -lImlib2

This is the minimal patch against w3m-0.5.3 that lets w3mimgdisplay link. A more proper patch should actually check for the presence of the X11 library in configure and use $(X_LIBS) or some similar token in Makefile.

--- a/Makefile.in   2011-01-04 04:22:18.000000000 -0500
+++ b/Makefile.in   2014-01-31 10:22:25.000000000 -0500
@@ -199,7 +199,7 @@
    $(CC) $(CFLAGS) -DDUMMY -c -o $@ $?

 $(IMGDISPLAY): w3mimgdisplay.o $(ALIB) w3mimg/w3mimg.a
-   $(IMGLINK) $(CFLAGS) -o $(IMGDISPLAY) w3mimgdisplay.o w3mimg/w3mimg.a $(LDFLAGS) $(LIBS) $(IMGLDFLAGS)
+   $(IMGLINK) $(CFLAGS) -o $(IMGDISPLAY) w3mimgdisplay.o w3mimg/w3mimg.a $(LDFLAGS) $(LIBS) $(IMGLDFLAGS) -L/usr/X11R6/lib -lX11

 w3mimgdisplay.o: w3mimgdisplay.c w3mimg/w3mimg.h
    $(CC) $(CFLAGS) $(IMGCFLAGS) -o $@ -c $(srcdir)/w3mimgdisplay.c

Discussion

  • Tatsuya Kinoshita

    Tatsuya Kinoshita - 2014-01-31

    In Debian w3m 0.5.3-14, fixed with another patch:
    https://github.com/tats/w3m/commit/bc4000470194df630837b2b0acd1ea4e9d1702b5

    See also Debian bug#734425:
    http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=734425

     
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.

SourceForge
  • Create a Project
  • Open Source Software
  • Business Software
  • Top Downloaded Projects
Company
  • About
  • Team
  • SourceForge Headquarters
    225 Broadway Suite 1600
    San Diego, CA 92101
    +1 (858) 422-6466
Resources
  • Support
  • Site Documentation
  • Site Status
  • SourceForge Reviews
SourceForge logo
© 2025 Slashdot Media. All Rights Reserved.
Terms Privacy Opt Out Advertise
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.