[W3af-svn-notify] [Task #146139] Right button on log window

[SourceForge.net <no...@so...>]

Task #146139 has been updated. 

Project: w3af
Subproject: gtkUi - Phase 2
Summary: Right button on log window
Complete: 100%
Status: Closed
Authority  : andresriancho
Assigned to: facundobatista

Description: Remove options that are disabled. Add a find to that right click contextual menu.

Follow-Ups:

-------------------------------------------------------
Date: 2008-02-29 09:09
By: facundobatista

Comment:
Fixed and separated the functionality, commited in r760.

-------------------------------------------------------
Date: 2008-02-28 23:02
By: andresriancho

Comment:
Functionality is finished, but:

- Right button, "Find ..." doesn't work. Actually when I tested it I threw this exception: "TypeError: _build_search() takes exactly 1 argument (2 given)" which is fixed in revision 756

- Could this be more object oriented and be a superclass from which I could inherit?

-------------------------------------------------------
Date: 2008-02-27 21:33
By: andresriancho

Comment:
The functionality is GREAT. Changed one little thing, instead of connecting self._find_next with "activate" I put "changed" (this is more "a la firefox").

The problem I see with the search as it was already implemented is that if I search for two different strings, the highlighting of the first one is still there when I search for the second one. 

And a rather visual problem, is that the X that closes the find is huuuuuge! =)

If possible, please create a class that inherits from some gtk class; like gtk.TextView or something like that so I can use the search feature everywhere!

-------------------------------------------------------
Date: 2008-02-27 16:35
By: facundobatista

Comment:
As of r743, most of the functionality is added. It actually needs some polish and cleanup, and the key bindings, but the rest works ok, :)

-------------------------------------------------------
Date: 2008-02-27 10:03
By: facundobatista

Comment:
Added capture of the ctrl-F and alteration of contextual menu, commited in r742.

I checked the standard programs in GTK, and the "find next" is ctrl-G, and also they have a "find previous", which is shift-ctrl-G.

However it would be nice that F3 and shift-F3 also be supported.

-------------------------------------------------------
Date: 2008-02-25 21:05
By: facundobatista

Comment:
Right button and Find, or CTRL-F, should bring a window to search. Right button and Find Next or F3 should search again. What's found whould be highlighted.

Optional: Try to replicate the behaviour of Firefox (see if there's something already done about this).

-------------------------------------------------------
For more info, visit:

http://sourceforge.net/pm/task.php?func=detailtask&project_task_id=146139&group_id=170274&group_project_id=55112