From: Sean M. <se...@ro...> - 2012-09-12 16:28:00
Attachments:
vxl-clang-static-analyzer.patch
|
Hi all, The following patch fixes some clang static analyzer warnings. If you don't know the tool, see here: <http://clang-analyzer.llvm.org> The changes are straightforward, low risk, and hopefully non-controversial. Cheers, -- ____________________________________________________________ Sean McBride, B. Eng se...@ro... Rogue Research www.rogue-research.com Mac Software Developer Montréal, Québec, Canada |
From: Peter V. <pet...@ya...> - 2012-09-13 07:18:40
|
I've applied the patches. -- Peter. In reply to: Sean McBride <se...@ro...> The following patch fixes some clang static analyzer warnings. If you don't know the tool, see here: <http://clang-analyzer.llvm.org> The changes are straightforward, low risk, and hopefully non-controversial. |
From: Sean M. <se...@ro...> - 2012-09-13 15:23:44
Attachments:
vxl-clang-static-analyzer2.patch
|
On Thu, 13 Sep 2012 08:18:32 +0100, Peter Vanroose said: >I've applied the patches. Thanks. Attached is round 2. :) This time, it's not really a patch so much as a collection of comments pointing out problems that someone who knows the code should fix. You'll see what I mean... Cheers, -- ____________________________________________________________ Sean McBride, B. Eng se...@ro... Rogue Research www.rogue-research.com Mac Software Developer Montréal, Québec, Canada |
From: Peter V. <pet...@ya...> - 2012-09-13 21:29:40
|
Yes, indeed difficult to make those corrections. Ideally, the developer should review the corresponding compiler warnings (if at all) and go back into the code to have it fixed in the logically most sensible way. I'll apply your patches, adding the comments, but I'm afraid that those will never make it to whoever is best placed to have a look at it... -- Peter. In reply to: Attached is round 2. :) This time, it's not really a patch so much as a collection of comments pointing out problems that someone who knows the code should fix. You'll see what I mean... |
From: Sean M. <se...@ro...> - 2012-09-13 21:33:02
|
On Thu, 13 Sep 2012 22:29:33 +0100, Peter Vanroose said: >Yes, indeed difficult to make those corrections. Ideally, the developer >should review the corresponding compiler warnings (if at all) and go >back into the code to have it fixed in the logically most sensible way. >I'll apply your patches, adding the comments, but I'm afraid that those >will never make it to whoever is best placed to have a look at it... hmmm, I'm not sure it makes sense to simply commit the patch as is... aren't said developers on this list? Cheers, -- ____________________________________________________________ Sean McBride, B. Eng se...@ro... Rogue Research www.rogue-research.com Mac Software Developer Montréal, Québec, Canada |