Re: [Vxl-maintainers] vsol_conic_2d

[Peter Vanroose <Peter.Vanroose@es...>]

> I need an ellipse whose parameters can be changed after construction 
> because I'd like to update them.

vsol_conic_2d now has two extra methods:
set_central_parameters and set_parabola_parameters.

The former sets the midpoint, main axes lengths and direction of main
axis of an ellipse (if both lenghts are positive) or hyperbola, 
the latter sets symmetry axis, top and excentricity of a parabola.

The arguments they take are identical to those taken by the
corresponding constructors, and should be identical to the
parameters returned by the ellipse_parameters, hyperbola_parameters
and parabola_parameters methods.


	Peter.


P.S. Note that there is (and has been for quite some time) an error in
     hyperbola_parameters; The added test in test_vsol_conic fails on this.

Re: [Vxl-maintainers] vsol_conic_2d

[<Peter.Vanroose@es...>]

>  set_ellipse_parameters(cx, cy, phi, width, height)

Yes, such a function can be added, I believe.

Currently the parent class vgl_conic<double> has the method
set(double a, double b, double c, double d, double e, double f)
to set conic parameters (i.e., coefficients of its equation).

Setting ellipse parameters will eventually just set these 6,
just like the "ellipse/hyperbola" constructor of vsol_conic_2d does.


	Peter.

[Vxl-maintainers] vsol_conic_2d

[David Serby <dserby@vi...>]

Hi,

why is it not possible to change the ellipse parameters (cx, cy, phi, 
width, height) after construction. Is there any reason why there is no 
setting-function like set_ellipse_parameters(cx, cy, phi, width, height)?
I need an ellipse whose parameters can be changed after construction 
because I'd like to update them.

David

Re: [Vxl-maintainers] vsol

[<Peter.Vanroose@es...>]

> /usr/local/src/vxl-source/gel/vsol/vsol_point_2d.h:56: warning: base
> class `class vsol_spatial_object_2d' should be explicitly initialized in
> the copy constructor

My guess is that this is caused by the constructor in the derived class
being inlined, while the parent class constructor isn't.

I propose to make all constructors in vsol_spatial_object_2d inline.


	Peter.

[Vxl-maintainers] vsol

[David Serby <dserby@vi...>]

Hello,

when I include the file vsol_point_2d.h and compile my program I get the
following compiler (g++ 2.95) warning:

/usr/local/src/vxl-source/gel/vsol/vsol_point_2d.h: In method
`vsol_point_2d::vsol_point_2d(const vsol_point_2d &)':
/usr/local/src/vxl-source/gel/vsol/vsol_point_2d.h:56: warning: base
class `class vsol_spatial_object_2d' should be explicitly initialized in
the copy constructor

I don't see why the base class constructor should be explicitely
initialized. Shouldn't it be implicitely invoked ? Where is the problem?

It's just a compiler warning and not an error, but nevertheless I'd
appreciate if it could be suppressed.

Regards,

David