Re: [VuFind-Tech] Book previews

[Demian K. <dem...@vi...>]

I haven't actually installed and run this code yet, but a couple more questions/comments first:


1.)    I notice that you are loading graphics from third-party sites.  Using Google's site for Google's graphics make sense, but why National Library of Australia for OpenLibrary?  Is there any reason not to include copies of these graphics with the trunk?  If we do stick with third-party URLs, it might also be wise to use HTTPS instead of HTTP to avoid security warnings on VuFind implementations running over SSL.

2.)    I see that you've added the book preview functionality to the holdings page by creating a public getLCCN method on the record driver and directly editing view-holdigns.tpl and Holdings.php.  I think it would be cleaner to keep getLCCN protected and to load this information via the record driver's getHoldings() method and associated holdings.tpl file.

Other than those minor points, this looks pretty good to me.  If you want me to actually run the code and provide further feedback, let me know...  but I figured I might as well wait for a second revision (and possibly completed HathiTrust support) before going that far.

thanks,
Demian


From: Eoghan Ó Carragáin [mailto:eog...@gm...]
Sent: Friday, August 06, 2010 11:51 AM
To: vuf...@li...
Subject: [VuFind-Tech] Book previews

Hi,
I uploaded a patch to JIRA (http://vufind.org/jira/browse/VUFIND-303) which adds Google Book Search and Open Library book previews to the search results page and full-record page. On the results page, the GBS and OpenLibrary lookups happen after the results & facets have loaded. It can be enabled/disabled in config.ini. It currently works with ISBN and LCCN (although these could do with being normalised/cleaned), but could be extended to work with OCLC numbers too. It also includes some unfinished work to add the same functionality for the Haithi Trust API.

I'm sure there is lots of room for improvement in this code, so feedback much appreciated.

Eoghan