Re: [VuFind-Tech] please test/comment

[Barnett, J. <jef...@ya...>]

I have seen relative links break other web pages, I have not tried this exact patch.  Right now we are trying hard to stabilize our setup, so I may not get a chance to try it before our deadline of 12/18, but maybe after that.  To be clear, it isn't that they don't resolve, but that they resolve incorrectly... ignoring the higher level symlink in favor of the "native" directory structure of the file system.

-----Original Message-----
From: Demian Katz [mailto:dem...@vi...] 
Sent: Friday, December 04, 2009 11:22 AM
To: Barnett, Jeffrey; Tuan Nguyen; vuf...@li...
Subject: RE: [VuFind-Tech] please test/comment

It's my understanding that relative image links in CSS files are supposed to be resolved by the web browser as being relative to the URL of the directory containing the CSS file.  I wouldn't expect server-side file system architecture to have any impact on how the browser resolves paths.  I could be mistaken about this, but if you haven't actually tested the patch yet, it might be worth a try to be sure it will really break your setup.  If you've already tested it and proven that it won't work, then I apologize for doubting you -- I just wanted to be sure.

A couple of other comments:

1.) If it turns out that the relative path thing won't break anybody's setups, I think some of the relative paths in the patch could be made even shorter...  for example:

    background-image:url(../../../../interface/themes/default/images/rc2.jpg);

could be simplified to:

    background-image:url(../images/rc2.jpg);

2.) If we can't safely get away from the PHP processing, I don't think we gain much by replacing $configArray['Site']['path'] with a local variable.  It might be worthwhile for readability purposes, but I wouldn't expect to see any significant performance change.  I'm sure accessing a variable directly is faster than indexing into a two-dimensional array, but it's still a fast memory operation either way.

- Demian

> -----Original Message-----
> From: Barnett, Jeffrey [mailto:jef...@ya...]
> Sent: Thursday, December 03, 2009 4:45 PM
> To: Tuan Nguyen; vuf...@li...
> Subject: Re: [VuFind-Tech] please test/comment
> 
> I can see the desirability of reducing calls to $configArray['Site'],
> but reliance on relative urls will break some sites (like mine) where
> different portions of the vufind directory tree reside on different
> file systems joined via symlinks.  What about an approach that fetched
> $configArray['Site'] once to a local variable and then reused that
> result for the rest of the processing?
> 
> -----Original Message-----
> From: Tuan Nguyen [mailto:tu...@yo...]
> Sent: Thursday, December 03, 2009 10:39 AM
> To: vuf...@li...
> Subject: [VuFind-Tech] please test/comment
> 
> It seems there are some unnecessary execution of css files and extra
> parsing of config.ini in themes/default/css. I cleaned up the css files
> as much as I can  so that we don't need to execute those css files any
> more.
> 
> 
> 
> 
> -----------------------------------------------------------------------
> -------
> Join us December 9, 2009 for the Red Hat Virtual Experience,
> a free event focused on virtualization and cloud computing.
> Attend in-depth sessions from your desk. Your couch. Anywhere.
> http://p.sf.net/sfu/redhat-sfdev2dev
> _______________________________________________
> Vufind-tech mailing list
> Vuf...@li...
> https://lists.sourceforge.net/lists/listinfo/vufind-tech