Menu

#287 CDetailView::GetLineData causing memory leaks.

v3.x
open
ltribble
None
5
2008-10-22
2008-10-22
No

Function located in DetailView.cpp was originally designed to return the pointer to the pString variable. pString was originally created with a new statement and never deleted.

Modified the function in the attached file by:

function now returns a string instead of a pointer
removed the new declaration so pString is automatically destroyed/deleted when out of context.

Discussion

  • Bobby Vocque

    Bobby Vocque - 2008-10-22

    DetailView.cpp

     
  • ltribble

    ltribble - 2008-10-22
    • milestone: --> v3.x
    • assigned_to: nobody --> ltribble
     
  • ltribble

    ltribble - 2008-10-22

    On review of this change, it looks like making a change like this would require a change to all who are using this fuction as well. Need to review further before applying this change.

     
  • Bobby Vocque

    Bobby Vocque - 2008-10-25

    detailview.h

     
  • Bobby Vocque

    Bobby Vocque - 2008-10-25

    Attaching files that contain definitions and functions related to this bug.
    File Added: DetailView.h

     
  • Bobby Vocque

    Bobby Vocque - 2008-10-25

    HexView.cpp

     
  • Bobby Vocque

    Bobby Vocque - 2008-10-25

    File Added: HexView.cpp

     
  • Bobby Vocque

    Bobby Vocque - 2008-10-25

    HexView.h

     
  • Bobby Vocque

    Bobby Vocque - 2008-10-25

    File Added: HexView.h

     
  • Bobby Vocque

    Bobby Vocque - 2008-10-25

    File Added: ScrollLineView.cpp

     
  • Bobby Vocque

    Bobby Vocque - 2008-10-25

    ScrollLineView.cpp

     
  • Bobby Vocque

    Bobby Vocque - 2008-10-25

    File Added: ScrollLineView.h

     
  • Bobby Vocque

    Bobby Vocque - 2008-10-25

    ScrollLineView.h

     
  • Bobby Vocque

    Bobby Vocque - 2008-10-25

    File Added: SummaryView.cpp

     
  • Bobby Vocque

    Bobby Vocque - 2008-10-25

    SummayView.cpp

     
  • Bobby Vocque

    Bobby Vocque - 2008-10-25

    The attached files contain all the definitions and references I had found relating to the problem description. My apologies for not listing all at the beginning.
    File Added: SummaryView.h

     
  • Bobby Vocque

    Bobby Vocque - 2008-10-25

    SummaryView.h

     

Log in to post a comment.