#670 Index Out of Bounds after marking observation discremant in phase plot

[Cliff Kotnik]

Index out of bounds exception when selecting an observation in the observation list or plot. Stack trace in Error1.txt and screen capture in Error1.JPG. Steps to reproduce:
1) New star from file in AAVSO upload format using Measurements.csv
2) Switch to phase plot, period 1, default epoch
3) In the Observations pane select the B observation at HJD 2468686.81162
4) View observation details and mark it as discrepant.
5) Click on the I observation at HJD 2458700.78623
6) java.lang.IndexOutOfBoundsException occurs.

[David Benn]

Hi Cliff

I was unable to click on the B ob at 2468686.81162 since it does not seem to be in the file you attached.

I clicked on the I observation at HJD 2458700.78623 but there was no error.

David

[David Benn]

Ignore that last. The B observation is at HJD 2468689.81162 not 2468686.81162, that was all.

I can definitely reproduce this:

java.lang.IndexOutOfBoundsException: Index: 44, Size: 44
at java.util.ArrayList.rangeCheck(ArrayList.java:657)
at java.util.ArrayList.get(ArrayList.java:433)
at org.aavso.tools.vstar.ui.model.plot.JDCoordSource.getXCoord(Unknown Source)
at org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getX(Unknown Source)

[David Benn]

Also, Cliff: do you see a single invalid observation line under the obs list pane, for the TYPE=EXTENDED line? I currently do, but not for all AAVSO Upload Format files, just this one.

[David Benn]

Two more things I've noticed:

• You don't have to be in phase plot mode to see this error; same in raw mode.
• Only Cousins I observations are affected (at least so far) after that specific B ob removal.

[David Benn]

Sometimes the series-index, item-index pair will have changed or have become non-existent. I'm currently choosing to ignore but log such events because all circumstances under which I have observed these so far appear to be benign and get in the way of other useful functionality such as seeing the info dialog. Logging them will allow ongoing exploration, especially in the case of non-benign effects should any arise.

See https://sourceforge.net/p/vstar/code/1714 and https://sourceforge.net/p/vstar/code/1717 for the code changes.

[David Benn]

Should decide whether to do anything more about this one. @clkotnik: thoughts?

[David Benn]

Should decide whether to do anything more about this one. @clkotnik: thoughts?

[Cliff Kotnik]

I think it makes sense to pause at this point and see if this is a problem for users.