#657 java.lang.IllegalArgumentException when AoV is used after DFT and vice versa

[Maksym Pyatnytskyy]

"java.lang.IllegalArgumentException: null" occured when one uses AoV after DFT and vice versa. This makes impossible to use [New Phase Plot] and other buttons of Period Analysis pane.
A scenario:
1) Start VStar
2) Open any observation data file.
3) Analysis -> DC DFT Standard scan..., do the scan.
4) Close plot pane.
4) Analysis -> AoV with period range..., enter appropriate values. Do the scan.
5) Click any of Top Hits (in the plot or in the table).
6) You will get an exception.

and vice versa:

1) Start VStar
2) Open any observation data file.
3) Analysis -> AoV with period range..., enter appropriate values, do the scan.
4) Close plot pane.
5) Analysis -> DC DFT Standard scan..., do the scan.
6) Click a Top Hit (in the plot or in the table).
7) You will get an exception.

[David Benn]

Hi Max. I was able to reproduce this bug a couple of days ago, inadvertently while analysing data. I can't do so again at the moment. Can you give me a target and JD range for which you see this? Thanks.

[Maksym Pyatnytskyy]

Hi David!
I've attached test data to reproduce the bug.
Steps to reproduce (VStar 2.20.0):
1) Load file via "New Star from File"
2) Analysis->DFT with Period range, low period=10, hight period=100,
resolution=0.1. Press Ok, periodogram will be shown
3) Close periodogram. Analysis->AoV with period range. Minimum period=10,
Maximum period=100, Resolution=0.1, Bins=10. Press Ok, periodogram will be
shown.
4) Now try to click a point in the periodogram or an item in the Top Hits
table. The error will occur (see the picture). After closing the error
dialog [New Phase Plot] button remains inactive.

And vice versa: try Analysis->AoV first, then Analysis->DFT with Period
range. Again the error occurs.

Regards,
Max

[image: image.png]

On Thu, 10 Oct 2019 at 00:11, David Benn david_benn@users.sourceforge.net
wrote:

Hi Max. I was able to reproduce this bug a couple of days ago,
inadvertently while analysing data. I can't do so again at the moment. Can
you give me a target and JD range for which you see this? Thanks.

---

• [bugs-and-features:#657]
  https://sourceforge.net/p/vstar/bugs-and-features/657/
  java.lang.IllegalArgumentException when AoV is used after DFT and vice
  versa*

Status: open
Group: Defect
Created: Fri Jun 07, 2019 12:27 PM UTC by Maksym Pyatnytskyy
Last Updated: Tue Oct 08, 2019 12:43 PM UTC
Owner: nobody
Attachments:

• Bug001.png
  https://sourceforge.net/p/vstar/bugs-and-features/657/attachment/Bug001.png
  (34.5 kB; image/png)

"java.lang.IllegalArgumentException: null" occured when one uses AoV after
DFT and vice versa. This makes impossible to use [New Phase Plot] and
other buttons of Period Analysis pane.
A scenario:
1) Start VStar
2) Open any observation data file.
3) Analysis -> DC DFT Standard scan..., do the scan.
4) Close plot pane.
4) Analysis -> AoV with period range..., enter appropriate values. Do the
scan.
5) Click any of Top Hits (in the plot or in the table).
6) You will get an exception.

and vice versa:

1) Start VStar
2) Open any observation data file.
3) Analysis -> AoV with period range..., enter appropriate values, do the
scan.
4) Close plot pane.
5) Analysis -> DC DFT Standard scan..., do the scan.
6) Click a Top Hit (in the plot or in the table).
7) You will get an exception.

---

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/vstar/bugs-and-features/657/

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/

[David Benn]

Hi Max

I’ve shared the candidate release with you.

Please let me know if you received the email from Dropbox.

I am unable to reproduce the bug with tge candidate 2.21.0 release.

Can you confirm?

David

On 10 Oct 2019, at 18:17, Maksym Pyatnytskyy mpyat2sf@users.sourceforge.net wrote:

Hi David!
I've attached test data to reproduce the bug.
Steps to reproduce (VStar 2.20.0):
1) Load file via "New Star from File"
2) Analysis->DFT with Period range, low period=10, hight period=100,
resolution=0.1. Press Ok, periodogram will be shown
3) Close periodogram. Analysis->AoV with period range. Minimum period=10,
Maximum period=100, Resolution=0.1, Bins=10. Press Ok, periodogram will be
shown.
4) Now try to click a point in the periodogram or an item in the Top Hits
table. The error will occur (see the picture). After closing the error
dialog [New Phase Plot] button remains inactive.

And vice versa: try Analysis->AoV first, then Analysis->DFT with Period
range. Again the error occurs.

Regards,
Max

[image: image.png]

On Thu, 10 Oct 2019 at 00:11, David Benn david_benn@users.sourceforge.net david_benn@users.sourceforge.net
wrote:

Hi Max. I was able to reproduce this bug a couple of days ago,
inadvertently while analysing data. I can't do so again at the moment. Can
you give me a target and JD range for which you see this? Thanks.

[bugs-and-features:#657] https://sourceforge.net/p/vstar/bugs-and-features/657/
https://sourceforge.net/p/vstar/bugs-and-features/657/ https://sourceforge.net/p/vstar/bugs-and-features/657/
java.lang.IllegalArgumentException when AoV is used after DFT and vice
versa*
Status: open
Group: Defect
Created: Fri Jun 07, 2019 12:27 PM UTC by Maksym Pyatnytskyy
Last Updated: Tue Oct 08, 2019 12:43 PM UTC
Owner: nobody
Attachments:

Bug001.png
https://sourceforge.net/p/vstar/bugs-and-features/657/attachment/Bug001.png https://sourceforge.net/p/vstar/bugs-and-features/657/attachment/Bug001.png
(34.5 kB; image/png)
"java.lang.IllegalArgumentException: null" occured when one uses AoV after
DFT and vice versa. This makes impossible to use [New Phase Plot] and
other buttons of Period Analysis pane.
A scenario:
1) Start VStar
2) Open any observation data file.
3) Analysis -> DC DFT Standard scan..., do the scan.
4) Close plot pane.
4) Analysis -> AoV with period range..., enter appropriate values. Do the
scan.
5) Click any of Top Hits (in the plot or in the table).
6) You will get an exception.

and vice versa:

1) Start VStar
2) Open any observation data file.
3) Analysis -> AoV with period range..., enter appropriate values, do the
scan.
4) Close plot pane.
5) Analysis -> DC DFT Standard scan..., do the scan.
6) Click a Top Hit (in the plot or in the table).
7) You will get an exception.

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/vstar/bugs-and-features/657/ https://sourceforge.net/p/vstar/bugs-and-features/657/
To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/ https://sourceforge.net/auth/subscriptions/
[bugs-and-features:#657] https://sourceforge.net/p/vstar/bugs-and-features/657/ java.lang.IllegalArgumentException when AoV is used after DFT and vice versa

Status: open
Group: Defect
Created: Fri Jun 07, 2019 12:27 PM UTC by Maksym Pyatnytskyy
Last Updated: Wed Oct 09, 2019 09:11 PM UTC
Owner: nobody
Attachments:

Bug001.png https://sourceforge.net/p/vstar/bugs-and-features/657/attachment/Bug001.png (34.5 kB; image/png)
"java.lang.IllegalArgumentException: null" occured when one uses AoV after DFT and vice versa. This makes impossible to use [New Phase Plot] and other buttons of Period Analysis pane.
A scenario:
1) Start VStar
2) Open any observation data file.
3) Analysis -> DC DFT Standard scan..., do the scan.
4) Close plot pane.
4) Analysis -> AoV with period range..., enter appropriate values. Do the scan.
5) Click any of Top Hits (in the plot or in the table).
6) You will get an exception.

and vice versa:

1) Start VStar
2) Open any observation data file.
3) Analysis -> AoV with period range..., enter appropriate values, do the scan.
4) Close plot pane.
5) Analysis -> DC DFT Standard scan..., do the scan.
6) Click a Top Hit (in the plot or in the table).
7) You will get an exception.

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/vstar/bugs-and-features/657/ https://sourceforge.net/p/vstar/bugs-and-features/657/
To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/ https://sourceforge.net/auth/subscriptions/

[Maksym Pyatnytskyy]

Hi David,

I have not received an email from Dropbox. Currently, I do not have an
active Dropbox account, is it required?

Best regards,
Max

On Thu, 10 Oct 2019 at 16:00, David Benn david_benn@users.sourceforge.net
wrote:

Hi Max

I’ve shared the candidate release with you.

Please let me know if you received the email from Dropbox.

I am unable to reproduce the bug with tge candidate 2.21.0 release.

Can you confirm?

David

[David Benn]

Hi Max

Hmm. Even with your supplied data file, I am having trouble reproducing this bug.

David

[Maksym Pyatnytskyy]

Hi David,

I've tested VStar 2.21 under Debian 9, OpenJDK:
openjdk version "1.8.0_181"
OpenJDK Runtime Environment (build 1.8.0_181-8u181-b13-1~deb9u1-b13)
OpenJDK 64-Bit Server VM (build 25.181-b13, mixed mode)

and the bug appears. It also appears when I try to use a new plugin
"Minimum Scatter Period Finder" after Analysis->DC DFT Standard Scan (or after DC
DFT with Period Range/Frequency Range) (see screenshot: test under Debian).

Best regards,
Max

On Sat, 26 Oct 2019 at 15:57, David Benn david_benn@users.sourceforge.net
wrote:

Hi Max

Hmm. Even with your supplied data file, I am having trouble reproducing
this bug.

David

[Cliff Kotnik]

I have reproduced this bug in 2 out of 4 attempts with 2.21.0 svn ver 1703. Attacted is my log for one of the failures. I tried to get more exact with reprocing this. Perhaps I am on to something:

From a fresh launch I open Max's test file.
I do the DC DFT with period as Max describes.
I then dismiss the dialog in 2 ways: a) Dismiss button or b) Dialog close X button
I then do AoV with period as Max describes.
I switch to top hits and pick the 3rd one 63.7.
In the a) case I do not get an error. In the b) case I do.

Hope this is reproducable by others and helps,
Cliff

[Maksym Pyatnytskyy]

I've reproduced the behavior mentioned by Cliff: indeed, when closing by [Dismiss] all works fine, after closing by dialog's [X] button the error occurs! Probably David almost always uses [Discard] while I almost always close windows and dialogs with [X] title button... So there is something missing in Close event handler I guess...

[David Benn]

Thanks verty much for this Cliff and Max. I can reproduce it too.

Agreed. What I was thinking too (event handler). Almost at work but will look at code after.

David

On 28 Oct 2019, at 06:26, Maksym Pyatnytskyy mpyat2sf@users.sourceforge.net wrote:

I've reproduced the behavior mentioned by Cliff: indeed, when closing by [Dismiss] all works fine, after closing by dialog's [X] button the error occurs! Probably David almost always uses [Discard] while I almost always close windows and dialogs with [X] title button... So there is something missing in Close event handler I guess...

[bugs-and-features:#657] https://sourceforge.net/p/vstar/bugs-and-features/657/ java.lang.IllegalArgumentException when AoV is used after DFT and vice versa

Status: open
Group: Defect
Created: Fri Jun 07, 2019 12:27 PM UTC by Maksym Pyatnytskyy
Last Updated: Sun Oct 27, 2019 05:30 PM UTC
Owner: nobody
Attachments:

Bug001.png https://sourceforge.net/p/vstar/bugs-and-features/657/attachment/Bug001.png (34.5 kB; image/png)
"java.lang.IllegalArgumentException: null" occured when one uses AoV after DFT and vice versa. This makes impossible to use [New Phase Plot] and other buttons of Period Analysis pane.
A scenario:
1) Start VStar
2) Open any observation data file.
3) Analysis -> DC DFT Standard scan..., do the scan.
4) Close plot pane.
4) Analysis -> AoV with period range..., enter appropriate values. Do the scan.
5) Click any of Top Hits (in the plot or in the table).
6) You will get an exception.

and vice versa:

1) Start VStar
2) Open any observation data file.
3) Analysis -> AoV with period range..., enter appropriate values, do the scan.
4) Close plot pane.
5) Analysis -> DC DFT Standard scan..., do the scan.
6) Click a Top Hit (in the plot or in the table).
7) You will get an exception.

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/vstar/bugs-and-features/657/ https://sourceforge.net/p/vstar/bugs-and-features/657/
To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/ https://sourceforge.net/auth/subscriptions/

[David Benn]

I’ve added handling for the event and calling the same cleanup() function that the Dismiss button handler calls.

I can’t reproduce the bug now.

On 28 Oct 2019, at 07:29, David Benn david_benn@users.sourceforge.net wrote:

Thanks verty much for this Cliff and Max. I can reproduce it too.

Agreed. What I was thinking too (event handler). Almost at work but will look at code after.

David

On 28 Oct 2019, at 06:26, Maksym Pyatnytskyy mpyat2sf@users.sourceforge.net mpyat2sf@users.sourceforge.net wrote:

I've reproduced the behavior mentioned by Cliff: indeed, when closing by [Dismiss] all works fine, after closing by dialog's [X] button the error occurs! Probably David almost always uses [Discard] while I almost always close windows and dialogs with [X] title button... So there is something missing in Close event handler I guess...

[bugs-and-features:#657] https://sourceforge.net/p/vstar/bugs-and-features/657/ https://sourceforge.net/p/vstar/bugs-and-features/657/ https://sourceforge.net/p/vstar/bugs-and-features/657/ java.lang.IllegalArgumentException when AoV is used after DFT and vice versa

Status: open
Group: Defect
Created: Fri Jun 07, 2019 12:27 PM UTC by Maksym Pyatnytskyy
Last Updated: Sun Oct 27, 2019 05:30 PM UTC
Owner: nobody
Attachments:

Bug001.png https://sourceforge.net/p/vstar/bugs-and-features/657/attachment/Bug001.png https://sourceforge.net/p/vstar/bugs-and-features/657/attachment/Bug001.png (34.5 kB; image/png)
"java.lang.IllegalArgumentException: null" occured when one uses AoV after DFT and vice versa. This makes impossible to use [New Phase Plot] and other buttons of Period Analysis pane.
A scenario:
1) Start VStar
2) Open any observation data file.
3) Analysis -> DC DFT Standard scan..., do the scan.
4) Close plot pane.
4) Analysis -> AoV with period range..., enter appropriate values. Do the scan.
5) Click any of Top Hits (in the plot or in the table).
6) You will get an exception.

and vice versa:

1) Start VStar
2) Open any observation data file.
3) Analysis -> AoV with period range..., enter appropriate values, do the scan.
4) Close plot pane.
5) Analysis -> DC DFT Standard scan..., do the scan.
6) Click a Top Hit (in the plot or in the table).
7) You will get an exception.

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/vstar/bugs-and-features/657/ https://sourceforge.net/p/vstar/bugs-and-features/657/ https://sourceforge.net/p/vstar/bugs-and-features/657/ https://sourceforge.net/p/vstar/bugs-and-features/657/
To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/ https://sourceforge.net/auth/subscriptions/ https://sourceforge.net/auth/subscriptions/ https://sourceforge.net/auth/subscriptions/
[bugs-and-features:#657] https://sourceforge.net/p/vstar/bugs-and-features/657/ java.lang.IllegalArgumentException when AoV is used after DFT and vice versa

Status: open
Group: Defect
Created: Fri Jun 07, 2019 12:27 PM UTC by Maksym Pyatnytskyy
Last Updated: Sun Oct 27, 2019 07:56 PM UTC
Owner: nobody
Attachments:

Bug001.png https://sourceforge.net/p/vstar/bugs-and-features/657/attachment/Bug001.png (34.5 kB; image/png)
"java.lang.IllegalArgumentException: null" occured when one uses AoV after DFT and vice versa. This makes impossible to use [New Phase Plot] and other buttons of Period Analysis pane.
A scenario:
1) Start VStar
2) Open any observation data file.
3) Analysis -> DC DFT Standard scan..., do the scan.
4) Close plot pane.
4) Analysis -> AoV with period range..., enter appropriate values. Do the scan.
5) Click any of Top Hits (in the plot or in the table).
6) You will get an exception.

and vice versa:

1) Start VStar
2) Open any observation data file.
3) Analysis -> AoV with period range..., enter appropriate values, do the scan.
4) Close plot pane.
5) Analysis -> DC DFT Standard scan..., do the scan.
6) Click a Top Hit (in the plot or in the table).
7) You will get an exception.

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/vstar/bugs-and-features/657/ https://sourceforge.net/p/vstar/bugs-and-features/657/
To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/ https://sourceforge.net/auth/subscriptions/

[David Benn]

I’ve added handling for the event and calling the same cleanup() function that the Dismiss button handler calls.

I can’t reproduce the bug now.

[David Benn]

Looks from the last comment that this can be closed. @mpyat2sf?

[Maksym Pyatnytskyy]

Yes, it could be closed, last time I tried AoV/DCDFT dialogs they worked properly.

[David Benn]

Closing for now. This may come again, given Cliff's and Max's comments.