Since a valflag of 'Y' in a database observation record denotes DELETED, the corresponding observation should not be included in the list of observations displayed in tables and plots.
Check that any other validation flag that denotes "deleted" is similarly acted upon.
This page documents the legal validation flags: https://sourceforge.net/apps/mediawiki/vstar/index.php?title=Valflag:
See also the corresponding discussion page: https://sourceforge.net/apps/mediawiki/vstar/index.php?title=Talk:Valflag:
The enum http://vstar.svn.sourceforge.net/viewvc/vstar/trunk/src/org/aavso/tools/vstar/data/ValidationType.java?view=markup&pathrev=212 and the getNextValidationType() and retrieveObservations() methods in http://vstar.svn.sourceforge.net/viewvc/vstar/trunk/src/org/aavso/tools/vstar/input/database/AAVSODatabaseObservationReader.java?revision=200&view=markup are central to this bug.
Handling all valfag values in http://vstar.svn.sourceforge.net/viewvc/vstar?view=rev&revision=213
Line 111 of DatabaseObservationReaderTest.testReadDeletedEpsAurObservation1() can be uncommented once this bug is fixed and that test should pass. Uncommenting it before the fix will yield a test failure.
See also https://sourceforge.net/tracker/index.php?func=detail&aid=2872525&group_id=263306&atid=1152052
Consider adding a constraint to the SQL query to ignore valflag='Y' obs rows.
See http://vstar.svn.sourceforge.net/viewvc/vstar?view=rev&revision=418. Fixed related unit test which now uses U Sco.
Tested with a small set of R LEO data that looked like this:
mysql> select name, JD, valflag from observations where name = "R LEO" and JD > 2455250 and JD < 2455260;
| name | JD | valflag |
| R LEO | 2455251.96667 | Z |
| R LEO | 2455258.28264 | Z |
| R LEO | 2455257.4708 | Z |
| R LEO | 2455259.34375 | Y |
| R LEO | 2455259.34375 | Z |
5 rows in set (16.22 sec)
and the one observation with valflag = 'Y" didn't show up so this looks good.
Log in to post a comment.
Sign up for the SourceForge newsletter:
You seem to have CSS turned off.
Please don't fill out this field.