#190 Disable JD fields when all data selected

Defect
closed-fixed
Adam
5
2010-04-18
2010-04-13
Adam
No

I noticed that I was able to add JD date into their respective fields even though I had all data checked. Perhaps we should disable those when the checkbox is selected.

Discussion

  • David Benn

    David Benn - 2010-04-13

    Agreed.

     
  • David Benn

    David Benn - 2010-04-13
    • assigned_to: david_benn --> adamweber
     
  • Adam

    Adam - 2010-04-15

    potential fix checked in at 473, marking as fixed awaiting verification.

     
  • Adam

    Adam - 2010-04-15
    • status: open --> open-fixed
     
  • David Benn

    David Benn - 2010-04-16

    Looks good Adam! I see now that we are not clearing the fields. This raises the question of whether the else case in:

    private ActionListener createAllDataCheckBoxActionListener() {
    ...
    }

    should set min/max JD again or just use the ones previously entered, if any. I'm inclined to think the latter. You?

    Also, re: error bar allowances on plot, we may also need to take account of the fact that if there's no user defined uncertainty values, we can look for HQUncertainty. We use that elsewhere in the code for table/plot display but need to check where.

     
  • Adam

    Adam - 2010-04-17

    I agree, I've made the changes in 474.

    I'd seen the uncertainty thing, but didn't do it because it seemed to me like that check was in a number of places and I didn't want to add another. However, I agree with the uniformity of it, so I'll go back and do it and update the other tracker item.

     
  • David Benn

    David Benn - 2010-04-18

    The change at 474 looks good. The change to AbstractObservationPlotPane caused null pointer exceptions when HQ uncertainty was not present. Fixed that at 476.

    I agree with you that it would be nice to unify this check so that one can just ask for the uncertainty value. We currently make the distinction in 2 other places, which isn't too bad I guess. There is another tracker out re: how this is displayed, so this could be revisited there. See https://sourceforge.net/tracker/?func=detail&aid=2975998&group_id=263306&atid=1152052

    I think we can close this.

     
  • David Benn

    David Benn - 2010-04-18
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks