Menu

#6 VOCP::Device::Vgetty::dial() fix

open
nobody
None
5
2004-02-13
2004-02-13
Jamin Ragle
No

o Fixed invocation of Modem::Vgetty::dial(),waitfor()
at the end of VOCP::Device::Vgetty::dial() to access
the correct object. (And a debug line to figure out
what was happening.)
o Added a 'return 1' at the end of
VOCP::Device::Vgetty::dial() otherwise tests would fail
where it was invoked like in this example:

> # Dail out to the target phone number.
> $Vocp->VOCP::Device::Vgetty::dial($ARGV[0])
> || VOCP::Util::error("Failed to Dial
$ARGV[0]");

Here is a trimmed VOCP::Device::Vgetty.pm diff from
original:
249,256c242,244
<
VOCP::Util::log_msg("\$self->{\'voicedevice\'}->{\'vgetty\'}->dial(\$destinatio\ n) -> $self->{'voicedevice'}->{'vgetty'}")
< if ($main::Debug > 1);
<
<
$self->{'voicedevice'}->{'vgetty'}->dial($destination);
<
$self->{'voicedevice'}->{'vgetty'}->waitfor($Vgetty{'READY'});
<
< return 1;
---
> $self->{'vgetty'}->dial($destination);
> $self->{'vgetty'}->waitfor($Vgetty{'READY'});
>

Discussion

  • Jamin Ragle

    Jamin Ragle - 2004-02-18

    Logged In: YES
    user_id=757998

    Hi, just adding a real patch file for the
    VOCP::Device::Vgetty.pm

     
  • Jamin Ragle

    Jamin Ragle - 2004-02-18

    Vgetty Patch file

     

Log in to post a comment.