here's a patch changing some basic stuff for making
tightvnc/win-code compliant to ISO C++ and therefore
usuable with GCC/MinGW. It would be nice if you could
integrate it as I'm maintaining a project which uses
parts of TightVNC-source-code and therefore my own
patchset could be shrinked... A few further things:
in some files you include rectlist.h although the
project only has RectList.h - case-sensivity plays no
role under Windows but when building using a
cross-compiler under Linux it does. Please change these
include-statements. This is the same for
vncCorbaConnect.h (sometimes vncCORBAConnect.h is
included) as well as in vncClient.cpp you include
Windows.h instead of windows.h. In vncDesktop.cpp you
use windows-pathname-convention (\ as dir-sep.) while
everywhere else you use / (which is better as supported
on all platforms) so please change it (patch includes
this). What about _ASSERT and _ASSERTE? Where are they
defined? They seem to be something MSC-specific, so I
have to define _ASSERT as assert in my additional
header. Therefore you could change that to assert.
Furthermore when you include a C++-header (fstream,
iostream) you include fstream.h, iostream.h which is
more then deprecated! Do you have to support other
compilers or such old MSC-versions?!
Ok, for now this is all, if you have a question please
contact me: tobias.doerffel/at/gmail/dot/com.
Log in to post a comment.