Hey Hannes,
On Thu, Sep 25, 2014 at 1:18 PM, Hannes Schüller <ha...@yl...> wrote:
> looks like a certain merge to me functionally. I'd just like to confirm
> that there are no major redundancies (code-wise) with the yank function.
Aside from the show_link() function extracted from the hoverlink
callback, there was nothing that really stood out to me as terribly
redundant. I copied the same pattern in the script() function which
was already somewhat repetitive to begin with, but it looked like a
marginal gain to bother with cleaning up that function at the moment.
It might be worth trying to refactor that a bit at some point as it
will likely only get worse, but I didn't consider it too urgent or
belonging in this patch.
Regards,
Morgan
|