vimprobable-users

[Vimprobable-users] [PATCH] Fixed wrong entries in command history

[Daniel C. <dan...@gm...>]

Hi!

I'm using the command history in vim, so I often was disappointed that the
command history didn't work well in vimprobable.

For example:

Run a command writing to message window :echo alert(1); that prints
'undefined' to the message window. If I looked for the last run comand in
history by tying : and hitting cursor key up, vimprobable suggests
':ndefined', but not the previous called command.

The attached patch fixes this behaviour by writing the history before running
the function associated with the command and only if the command was found.

Daniel

Re: [Vimprobable-users] [PATCH] Fixed wrong entries in command history

[Hannes S. <ha...@yl...>]

Hi!

Daniel Carl <dan...@gm...> wrote: 
> The attached patch fixes this behaviour by writing the history before
> running the function associated with the command and only if the
> command was found.

While I appreciate the bug being fixed, I don't like the functional
change. The only time I really use the command history is when I
mistyped something. So I recall what I typed and correct it. This would
not be possible anymore.

Hannes

Re: [Vimprobable-users] [PATCH] Fixed wrong entries in command history

[Daniel C. <dan...@gm...>]

Hi Hannes!
On Tue, Apr 10, 2012 at 05:21:36PM +0200, Hannes Schüller wrote:
> While I appreciate the bug being fixed, I don't like the functional
> change. The only time I really use the command history is when I
> mistyped something. So I recall what I typed and correct it. This would
> not be possible anymore.
> 
> Hannes

You are right, vim does also save wrong types commands, and so we shoud do it
also.

Attached patch fixed mentioned bug and allowes also to save invalid commands
in history.

Re: [Vimprobable-users] [PATCH] Fixed wrong entries in command history

[Hannes S. <ha...@yl...>]

Daniel Carl <dan...@gm...> wrote:
> On Tue, Apr 10, 2012 at 05:21:36PM +0200, Hannes Schüller wrote:
> > While I appreciate the bug being fixed, I don't like the functional
> > change. The only time I really use the command history is when I
> > mistyped something. So I recall what I typed and correct it. This
> > would not be possible anymore.
> 
> You are right, vim does also save wrong types commands, and so we
> shoud do it also.
> 
> Attached patch fixed mentioned bug and allowes also to save invalid
> commands in history.

Looking good - thanks!

Hannes

Re: [Vimprobable-users] [PATCH] Fixed wrong entries in command history

[Hannes S. <ha...@yl...>]

This, and the additional patch, has now been merged. Thanks again!

Hannes