vimprobable-users

[Vimprobable-users] [PATCH] Remove feedback for toggled proxy.

[Daniel C. <dan...@gm...>]

The feedback caused broken lines in command history. Feedback was removed
because no other :command gives feedback about his state.

Daniel
---
 main.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/main.c b/main.c
index eb1d66f..ef97d1a 100644
--- a/main.c
+++ b/main.c
@@ -2041,7 +2041,6 @@ toggle_proxy(gboolean onoff) {
 
     if (onoff == FALSE)  {
         g_object_set(session, "proxy-uri", NULL, NULL);
-        give_feedback("Proxy deactivated");
     } else  {
         filename = (char *)g_getenv("http_proxy");
 
@@ -2063,7 +2062,6 @@ toggle_proxy(gboolean onoff) {
                 proxy_uri = soup_uri_new(filename);
             }
             g_object_set(session, "proxy-uri", proxy_uri, NULL);
-            give_feedback("Proxy activated");
         } 
     }
 }
-- 
1.7.4.1

Re: [Vimprobable-users] [PATCH] Remove feedback for toggled proxy.

[Hannes S. <ha...@yl...>]

Daniel Carl <dan...@gm...> wrote:
> The feedback caused broken lines in command history. Feedback was
> removed because no other :command gives feedback about his state.

While I agree wih your comment in the other thread that feedback is not
necessary if this is set on startup, I don't think removing this
completely is the way to go. If it causes a problem with the command
history, that interference problem should be fixed instead. Can you
provide steps to reproduce the problem?

Hannes

Re: [Vimprobable-users] [PATCH] Remove feedback for toggled proxy.

[Daniel C. <dan...@gm...>]

On Fri, Nov 04, 2011 at 09:00:01AM +0100, Hannes Schüller wrote:
> While I agree wih your comment in the other thread that feedback is not
> necessary if this is set on startup, I don't think removing this
> completely is the way to go. If it causes a problem with the command
> history, that interference problem should be fixed instead. Can you
> provide steps to reproduce the problem?

For me the feedback makes no sense, if I :set proxy=true I trust that
proxying is anabled, the feedback would also be given when the webkit
wouldn't allow proxy. In this case the feedback did'nt reflect the real
state of the setting, it shows the user that he typed ':set proxy=...',
nothing more. I think when we feedback the setting for proxy we should
do this also for other settings for exmaple 'scripts' or 'images'
to keep it consitent.

Maybe we can implement a way to readout values of setting variables like
in vim the ':set variable?'. But this might be a useless and overbloated
feature for the most users.

To Reproduce:
- run some commands :set proxy=true, :set scripts=false
- switch to command mode with :
- use up-cursor-key -> ':set scripts=false' appears
- use down-cursomr-key -> ':roxy activated' appears

Daniel

Re: [Vimprobable-users] [PATCH] Remove feedback for toggled proxy.

[Hannes S. <ha...@yl...>]

I hope that with the latest upgrade, the issue of "feedback or not"
will become more visible to regular users. Maybe someone will have an
opinion then.

Hannes

Re: [Vimprobable-users] [PATCH] Remove feedback for toggled proxy.

[Jason R. <jas...@gm...>]

On 04/12/11 at 10:08pm, Hannes Schüller wrote:
> I hope that with the latest upgrade, the issue of "feedback or not"
> will become more visible to regular users. Maybe someone will have an
> opinion then.
> 
If you are referring to the 'Proxy Activated' in the status bar everytime I load
a page, then yes - I would like to see it removed. I already know that I am
running a proxy :)

Cheers,

/J

-- 

Jason Ryan
http://jasonwryan.com/

Re: [Vimprobable-users] [PATCH] Remove feedback for toggled proxy.

[Hannes S. <ha...@yl...>]

Merged