vimprobable-users Mailing List for Vimprobable (Page 14)
Vimprobable is a lean web browser optimised for full keyboard control
Brought to you by:
hanness
Menu
▾
▴
vimprobable-users — Mailing list for Vimprobable users
You can subscribe to this list here.
| 2011 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
(77) |
Sep
(44) |
Oct
(43) |
Nov
(38) |
Dec
(14) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2012 |
Jan
(40) |
Feb
(18) |
Mar
(12) |
Apr
(25) |
May
(12) |
Jun
(13) |
Jul
(17) |
Aug
(3) |
Sep
(20) |
Oct
(42) |
Nov
(9) |
Dec
(2) |
| 2013 |
Jan
(9) |
Feb
(29) |
Mar
(9) |
Apr
(7) |
May
(38) |
Jun
|
Jul
(7) |
Aug
|
Sep
(5) |
Oct
(10) |
Nov
(11) |
Dec
(1) |
| 2014 |
Jan
(16) |
Feb
(18) |
Mar
(11) |
Apr
(5) |
May
(13) |
Jun
(5) |
Jul
(5) |
Aug
(7) |
Sep
(30) |
Oct
|
Nov
|
Dec
(26) |
| 2015 |
Jan
(5) |
Feb
(19) |
Mar
(8) |
Apr
(15) |
May
(4) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
(16) |
Dec
(10) |
| 2016 |
Jan
|
Feb
(1) |
Mar
(14) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: Hannes S. <ha...@yl...> - 2013-02-24 16:05:38
|
Daniel Carl <dan...@gm...> wrote: > Hannes Schüller <ha...@yl...> wrote: > > > This does not work for me. Because this leads to the URL > > > 'file://./index.html' which could not be found. > > > > Eh? Works for me. > > I've tested it with the version of master branch, but it did not work > for me. It's independent if vimprobable is started from HOME_DIR or > from somewhere else. Also the proxy settings did not change the > behaviour for me. OK, that's definitely buggy behaviour then which needs to be reliably fixed one way or the other. Hannes |
|
From: Daniel C. <dan...@gm...> - 2013-02-24 16:03:01
|
Hannes Schüller <ha...@yl...> wrote: > > This does not work for me. Because this leads to the URL > > 'file://./index.html' which could not be found. > > Eh? Works for me. I've tested it with the version of master branch, but it did not work for me. It's independent if vimprobable is started from HOME_DIR or from somewhere else. Also the proxy settings did not change the behaviour for me. I guess that this could be a webkit behaviour. Daniel |
|
From: Hannes S. <ha...@yl...> - 2013-02-24 15:51:04
|
Daniel Carl <dan...@gm...> wrote: > Hannes Schüller <ha...@yl...> wrote: > > The second one, I don't really consider a problem, to be honest. You > > could easily just write > > > > vimprobable ./index.htm > > This does not work for me. Because this leads to the URL > 'file://./index.html' which could not be found. Eh? Works for me. Hannes |
|
From: Daniel C. <dan...@gm...> - 2013-02-24 15:42:42
|
Hi!
Hannes Schüller <ha...@yl...> wrote:
> The second one, I don't really consider a problem, to be honest. You
> could easily just write
>
> vimprobable ./index.htm
This does not work for me. Because this leads to the URL 'file://./index.html'
which could not be found.
> Does anyone else have an opinion?
In my opinion the stat call isn't required. I think the '/' or './' should
be enough. But out of the none working vimprobable2 ./index.html we should use
the realpath on the file before creating the URL.
By the way we can reduce the code by replacing:
new = g_malloc(sizeof("file://") + len);
strcpy(new, "file://");
memcpy(&new[sizeof("file://") - 1], s, len + 1);
by:
uri = g_strdup_printf("file://%s", s);
I've made a little patch that applies to the master that demonstrates what I
want to have. But this didn't check if the realpath returned a value or not,
but as an example this should be enough.
Daniel
|
|
From: Hannes S. <ha...@yl...> - 2013-02-24 15:16:44
|
Hi! Morgan Howe <mt...@gm...> wrote: > I look at a lot of test generated html output and the like, so I > frequently hit problems with file paths. Because of the URI, things > would only open properly if I provided a full path, or something that > would be expanded by the shell into a full path such as > ~/html/index.html. Modified to use realpath() to fix this issue. It > would also fail to detect file parameters without a "/" in the path > (e.g. "index.html"), so changed to use stat() instead of looking for > "/" or "./" when determining if an argument is a file. This takes care > of any issues I have run into with using vimprobable to view local > files. Hmm... well, this seems to work as advertised, but I'd like to hear some opinions. As far as I can see, your problem boils down to a) relative paths not being recognised (e.g. ../dir/file.htm). b) you assuming that . should be in the search path (e.g. index.htm). The second one, I don't really consider a problem, to be honest. You could easily just write vimprobable ./index.htm on your command line. Your solution would make it impossible to call URLs from a directory which has a file or subdirectory with the same name as the URL. E.g. if your file system looks like this: . .. www.example.org and you call vimprobable www.example.org it will call the local directory instead of the URL. No workaround possible. Before someone argues that this is a rather academic example, I would like to point out that such a directory structure is not so uncommon on machines used for web development. The first one, though, I cannot really argue against. In the end, I would say it is a matter of policy what the browser should 'assume', i.e. what it should give preference to. Right now, by using a very restrictive definition of calling local files, external URLs are always given preference. I'm not totally against changing this a bit in the way you describe. Does anyone else have an opinion? Hannes |
|
From: Daniel C. <dan...@gm...> - 2013-02-24 15:14:52
|
Hi Matto Fransen, matto fransen <ma...@ma...> wrote: > Do you have a single patch with all your patches combined? Here is it, hope it applies well. Daniel |
|
From: Hannes S. <ha...@yl...> - 2013-02-24 15:06:05
|
Hi Ludo! Ludo Beckers <la...@gm...> wrote: > There's no README file, and the INSTALL file isn't clear to me at all. > It says: > 1. Edit config.h and Makefile > --> it doesn't say how or why? (I can open 'em in gvim, but don't > know what to edit) You only need to edit these if you want to customise the browser on source level. If you're happy with the defaults and the run-time configuration options, simply skip this step. > 2. make > You need: libwebkit-1.0 >= 1.1.11 > libgtk+-2.0 > libsoup-2.4 > --> checked in synaptic, and it looks like it's all installed (be it > slightly different with gtk-stuff in the name; I guess it's ok) > 3. Optionally, make install > --> Here's what I tried: > > ./configure > bash: ./configure: Bestand of map bestaat niet Well, INSTALL does not say anything about running a configure script, does it? So don't. There is none. "Usually" (i.e. following that tutorial page you read), that script would create a Makefile for you based on your environment, but as you noticed, Vimprobable already comes with one. > make > cc -MMD -c `pkg-config --cflags gtk+-2.0 webkit-1.0 libsoup-2.4` > -D_XOPEN_SOURCE=500 callbacks.c -o callbacks.o > /bin/sh: 1: pkg-config: not found > In file included from callbacks.c:10:0: > includes.h:10:20: fatale fout: stdlib.h: Bestand of map bestaat niet > compilation terminated. > make: *** [callbacks.o] Fout 1 You need to install the development versions of the tools and libraries required by the browser. The first error refers to pkg-config not being found which you should be able to install through your packet manager. Then, install the libraries as listed in INSTALL, but the versions ending in -dev. Since you seem to have virtually no development libs at all installed on your system so far, this should resolve to quite a number. After than, try make again. Hannes |
|
From: Ludo B. <la...@gm...> - 2013-02-24 14:56:43
|
The demo-video I saw about vimprobable is great, and on the site it's well explained how to add the ppa via terminal. So far so good, but after that I'm lost. I've tried installing with the help of http://www.tuxfiles.org/linuxhelp/softinstall.html but it doesn't match with the instructions. There's no README file, and the INSTALL file isn't clear to me at all. It says: 1. Edit config.h and Makefile --> it doesn't say how or why? (I can open 'em in gvim, but don't know what to edit) 2. make You need: libwebkit-1.0 >= 1.1.11 libgtk+-2.0 libsoup-2.4 --> checked in synaptic, and it looks like it's all installed (be it slightly different with gtk-stuff in the name; I guess it's ok) 3. Optionally, make install --> Here's what I tried: ./configure bash: ./configure: Bestand of map bestaat niet make cc -MMD -c `pkg-config --cflags gtk+-2.0 webkit-1.0 libsoup-2.4` -D_XOPEN_SOURCE=500 callbacks.c -o callbacks.o /bin/sh: 1: pkg-config: not found In file included from callbacks.c:10:0: includes.h:10:20: fatale fout: stdlib.h: Bestand of map bestaat niet compilation terminated. make: *** [callbacks.o] Fout 1 make install cc -MMD -c `pkg-config --cflags gtk+-2.0 webkit-1.0 libsoup-2.4` -D_XOPEN_SOURCE=500 callbacks.c -o callbacks.o /bin/sh: 1: pkg-config: not found In file included from callbacks.c:10:0: includes.h:10:20: fatale fout: stdlib.h: Bestand of map bestaat niet compilation terminated. make: *** [callbacks.o] Fout 1 I'm not totally new to Linux and not afraid of the CLI, but a total greenhorn with installing stuff otherwise than via synaptic. So please, the right commands to install in the right location are...? Thanks on forehand -- Ludo |
|
From: Daniel C. <dan...@gm...> - 2013-02-22 20:02:11
|
Hi! The heavy restructuring of the code left a bug in the command history saving. Following patch fixes that. Daniel |
|
From: Morgan H. <mt...@gm...> - 2013-02-21 08:53:21
|
Greetings, I look at a lot of test generated html output and the like, so I frequently hit problems with file paths. Because of the URI, things would only open properly if I provided a full path, or something that would be expanded by the shell into a full path such as ~/html/index.html. Modified to use realpath() to fix this issue. It would also fail to detect file parameters without a "/" in the path (e.g. "index.html"), so changed to use stat() instead of looking for "/" or "./" when determining if an argument is a file. This takes care of any issues I have run into with using vimprobable to view local files. Regards, Morgan |
|
From: Daniel C. <dan...@gm...> - 2013-02-03 19:22:36
|
Hi! I've added to many g_free in the _resume_from_editor function that crashed vimprobable after the editor was closed. Daniel |
|
From: Daniel C. <dan...@gm...> - 2013-02-03 18:25:55
|
Hi Hannes! > I think this is a good idea, but as you probably guessed (and noticed, > seeing your followup patch), such a major change will also need major > testing. I will get to it by using your version for my regular work, > but it will take some time to gain overall confidence. Testing by > others would be appreciated, too, of course! If the refactored code needs major testing, we can also test some more patches too:) Today I spent some time to check vimprobable for memory leaks with valgrind and found some none freed strings in conjunction with the values filled by jsapi_evaluate_script. It isn't easy for me to under stand the code related to the editor feature - which of the variables 'value' or 'message' contains a newly allocated string and when can they be freed. At the moment I've put in some possible missed g_free() calls, but I'm not sure if this was done right. In generals wen should find a way to reduce the number of g_free calls in the open_editor function, if this is possible. During the hunting of memory leaky I found out, that the hint could not be cleaned/removed if the incremental search feature was disabled. This problem is fixed in patch 07-Fixed-wrong-placed-ifdef-ENABLE_INCREMENTAL_SEARCH.patch. Like HP annotated in the code, there are still heavy memory leaks in complete function. But this function is difficult to understand. I think we should split the logic and have a function that build up a list of matching items (for each completion type 'commands', 'settings', 'tags', 'url-history'), and another function to visualize these items to reduce the complexity of this part of code. In the way the complete function is implemented at the moment, I can't see when the memory should be freed and when not. Daniel |
|
From: Hannes S. <ha...@yl...> - 2013-02-03 12:24:57
|
Hi Daniel, Daniel Carl <dan...@gm...> wrote: > Following patches structures nearly all global variables into some > structs that are put together in a single client instance. I know > that is a large change, but it's better to read and to maintain (at > least for me). I think this is a good idea, but as you probably guessed (and noticed, seeing your followup patch), such a major change will also need major testing. I will get to it by using your version for my regular work, but it will take some time to gain overall confidence. Testing by others would be appreciated, too, of course! Hannes |
|
From: Daniel C. <dan...@gm...> - 2013-02-03 12:23:17
|
Oh no! I forgot the debugging code! How can I make souch a mistake within 5 changed lines? I think I should keep my fingers from the code today. Daniel |
|
From: Daniel C. <dan...@gm...> - 2013-02-03 12:17:42
|
Hi! I have removed the possibility to read the winid given by -e option also as a decimal number. This patch readded this part of code, so that vimprobable works also for older version of tabbed or other applications. Daniel |
|
From: Daniel C. <dan...@gm...> - 2013-02-02 20:22:58
|
Hi! Following patches structures nearly all global variables into some structs that are put together in a single client instance. I know that is a large change, but it's better to read and to maintain (at least for me). Daniel Carl (2): Added structs to move global variables out of the way. Use the BUF_SIZE constant for the rememberedURL too. config.h | 11 +- main.c | 659 ++++++++++++++++++++++++++++----------------------------- main.h | 60 ++++++ utilities.c | 45 ++-- utilities.h | 2 +- vimprobable.h | 8 +- 6 files changed, 420 insertions(+), 365 deletions(-) |
|
From: Leonardo T. <ia...@gm...> - 2013-02-01 23:20:28
|
On Fri, Feb 01, 2013 at 09:12:27PM +0100, Hannes Schüller wrote: > > On Tue, Jan 29, 2013 at 10:36:21PM +0100, Hannes Schüller wrote: > So is there a changeset between the versions in pkgsrc-2012Q3 and > pkgsrc-2012Q4? Also, is there somewhere I can see the changes from the > vanilla source? There is no change from the vanilla source and also the vimprobable2 package has not changed between 2012Q3 and 2012Q4 (only its dependencies are changed). Ciao, L. |
|
From: Hannes S. <ha...@yl...> - 2013-02-01 20:14:32
|
Leonardo Taccari <ia...@gm...> wrote: > On Tue, Jan 29, 2013 at 10:36:21PM +0100, Hannes Schüller wrote: > > What is both of that in "our" version numbers? > > Ops, I forgot to say that... always vimprobable2-1.2.0. So is there a changeset between the versions in pkgsrc-2012Q3 and pkgsrc-2012Q4? Also, is there somewhere I can see the changes from the vanilla source? Hannes |
|
From: Leonardo T. <ia...@gm...> - 2013-01-29 22:06:57
|
On Tue, Jan 29, 2013 at 10:36:21PM +0100, Hannes Schüller wrote: > Could you set another home page in your config file and see what > happens? I set as homepage "http://www.netbsd.org" but the behaviour is the same. > What is both of that in "our" version numbers? Ops, I forgot to say that... always vimprobable2-1.2.0. About pkgsrc-2012Q3 dependencies: o libsoup24-2.38.1nb2 o gtk2+-2.24.12nb3 o webkit-gtk-1.8.3nb2 Ciao, L. |
|
From: Hannes S. <ha...@yl...> - 2013-01-29 21:36:26
|
Leonardo Taccari <ia...@gm...> wrote: > I'm trying to use vimprobable2 on NetBSD/i386 6.0 but it crashes > immediatly. Could you set another home page in your config file and see what happens? > vimprobable2 worked with pkgsrc-2012Q3 but it does not work with > pkgsrc-2012Q4 (the current stable version). What is both of that in "our" version numbers? Hannes |
|
From: Leonardo T. <ia...@gm...> - 2013-01-29 21:11:26
|
Hello, I'm trying to use vimprobable2 on NetBSD/i386 6.0 but it crashes immediatly. The dependencies of vimprobable2 are (this information may be particulary useful for the version): o libsoup24>=2.38.1nb2 o webkit-gtk>=1.8.3nb4 o gtk2+>=2.24.13nb2 Here the log: [...] (vimprobable2:24672): libsoup-WARNING **: Could not set SSL credentials from '/etc/ssl/certs/ca-certificates.crt': Apertura del file "/etc/ssl/certs/ca-certificates.crt" non riuscita: No such file or directory (vimprobable2:24672): GLib-Net-WARNING **: couldn't load TLS file database: Apertura del file "/etc/ssl/certs/ca-certificates.crt" non riuscita: No such file or directory (vimprobable2:24672): GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed (vimprobable2:24672): GLib-Net-WARNING **: couldn't load TLS file database: Apertura del file "/etc/ssl/certs/ca-certificates.crt" non riuscita: No such file or directory (vimprobable2:24672): GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed Memory fault (core dumped) [...] Here is the output of "bt" of gdb(1): [...] (gdb) bt #0 0xb680a5b6 in ?? () #1 0xb9a366e8 in JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::ScopeChain Node*, JSC::JSObject*) () from /usr/pkg/lib/libjavascriptcoregtk-1.0.so.0 #2 0xb9b265de in JSC::evaluate(JSC::ExecState*, JSC::ScopeChainNode*, JSC::SourceCode const&, JSC::J SValue, JSC::JSValue*) () from /usr/pkg/lib/libjavascriptcoregtk-1.0.so.0 #3 0xb99b82cc in JSEvaluateScript () from /usr/pkg/lib/libjavascriptcoregtk-1.0.so.0 #4 0x0804d272 in jsapi_evaluate_script (script=<optimized out>, value=0xbfbfe428, message=0xbfbfe424) at main.c:1487 #5 0x08052a32 in notify_event_cb (widget=0xb6e957f8, event=0xb6e5bdf0, user_data=0x0) at main.c:679 #6 0xb9dbae84 in ?? () from /usr/pkg/lib/libgtk-x11-2.0.so.0 #7 0xb9317e2a in g_closure_invoke () from /usr/pkg/lib/libgobject-2.0.so.0 #8 0xb9329b9c in ?? () from /usr/pkg/lib/libgobject-2.0.so.0 #9 0xb9331d6a in g_signal_emit_valist () from /usr/pkg/lib/libgobject-2.0.so.0 #10 0xb93321e2 in g_signal_emit () from /usr/pkg/lib/libgobject-2.0.so.0 #11 0xb9eeb09e in ?? () from /usr/pkg/lib/libgtk-x11-2.0.so.0 #12 0xb9db972c in gtk_main_do_event () from /usr/pkg/lib/libgtk-x11-2.0.so.0 #13 0xb98ecbfa in ?? () from /usr/pkg/lib/libgdk-x11-2.0.so.0 #14 0xb926edc5 in g_main_context_dispatch () from /usr/pkg/lib/libglib-2.0.so.0 #15 0xb926f168 in ?? () from /usr/pkg/lib/libglib-2.0.so.0 #16 0xb926f5a3 in g_main_loop_run () from /usr/pkg/lib/libglib-2.0.so.0 #17 0xb9db8131 in gtk_main () from /usr/pkg/lib/libgtk-x11-2.0.so.0 #18 0x08053f5b in main (argc=1, argv=0xbfbfebc8) at main.c:2876 [...] Where main.2876 is the call to gtk_main()... vimprobable2 worked with pkgsrc-2012Q3 but it does not work with pkgsrc-2012Q4 (the current stable version). I would like to contribute in order to fix a possible bug, so feel free to contact me in order to test patches. Also let me know if I should send the .core. Thanks in advance, L. |
|
From: Daniel C. <dan...@gm...> - 2013-01-28 20:32:26
|
Hi! Inspired from the suckkless surf browser, I added the patch to show the webinspector in a vertical and resizable pane of the current window. This make the inspection easier in context with tabbed. Daniel |
|
From: Hannes S. <ha...@yl...> - 2013-01-27 17:15:38
|
Daniel Carl <dan...@gm...> wrote: > There was already a missed g_free(). Thanks, going into the next release! Hannes |
|
From: Daniel C. <dan...@gm...> - 2013-01-27 17:00:22
|
Hi! There was already a missed g_free(). Daniel |
|
From: Hannes S. <ha...@yl...> - 2013-01-27 14:23:46
|
Hi, both versions are now available on the website and the code repository. New feature (Vimprobable2): - Allowing runtime/vimprobablerc definition of new colon commands. New commands can be mapped to any existing command line (including the ones which take arguments). Example: map :bmatag1=:bookmark tag1 will make the command "bmatag1" save a bookmark of the current page including "tag1" automatically. Bug fixes: - Various man page fixes & corrections - Memory leak fix in command history Thanks to Marcos Cruz, Daniel Carl and Jason Ryan for their contributions to this release! Hannes |
2 messages has been excluded from this view by a project administrator.
