Re: [Vimprobable-users] F keybinding does not work

[Daniel C. <dan...@gm...>]

Daniel Carl
Jason Ryan <jas...@gm...> wrote:
> This has been around for a while; this small patch for hinting.js will fix
> it. An unfortunate side-effect seems to be that it will
> crash the original window when you use the mouse to "open in new tab";
> I don't use the mouse so it doesn't bother me, but caveat emptor etc…
> 
> /J
> 
> 
> @@ -395,11 +403,12 @@
>         var oldTarget = elem.target;
> 
>         /* set target to open in new window */
> -        elem.target = "_blank";
> +        /* elem.target = "_blank";
>         _clickElement(elem);
>         elem.target = oldTarget;
> 
> -        return "done;";
> +        return "done;"; */
> +        return "tabopen;" + elem.href;
>     }

This patch does only work for normal links if the hinted element uses onclick
or something similar this would not work. I see often pages with links like
'<a href="#" onclick="doFancyThings(); return false">' and sometimes this are
not even liks but span-Elements.

Daniel