Re: [Vimprobable-users] bug with

[DC <dc...@sy...>]

Marcos Cruz <vimprobable_list_00@...> writes:

> 
> Hi all,
> 
> In order to deactivate the "d" key binding the soft way, I have "map d
> stop" in <.vimprobablerc> (an 'unmap' command or a 'noop' action would
> be nice, I think we talked about it some time ago). But the mapping
> doesn't work, it doesn't override the value in <keymap.h>.
> 
> I'm using Vimprobable2 1.4.0 on Raspbian, but this problem happened with
> a pathched 1.3.0 as well.
> 
> In order to find out the error conditions, I have being moving "map d
> jumpbottom", executing Vimprobable and pressing "d", again and again.
> My provisional conclusion is "map d" overrides the default configuration
> only if it's not the first 'map' command in the file, and if there are
> some other commands before the first 'map'.
> 
> Then I noticed the "d" mapping is the last one defined in <keymap.h>,
> what made me suspect.  I've exchanged the position of the last two key
> bindings in the array, compiled... and the problem was solved. Now "map
> d" works in any position of <.vimprobablerc> (and presumably the other
> mapping is affected).
> 
> It seems there's a bug. I hope this little investigation helps to remove
> it.
> 
> Marcos
>

Hi, 
I can confirm this on 1.4.0. The bug resided on the function changemapping().
As described the last element on the keys list is skipped and not available
to rebind/override.

Fix is on this commit: https://github.com/desyncr/vimprobable/
commit/050a96f849e7b14ba2e2629268ee559c5afe6856

Greets.