Re: [Vimprobable-users] Editor patch evolution
Vimprobable is a lean web browser optimised for full keyboard control
Brought to you by:
hanness
From: Matthew C. <je...@gm...> - 2012-10-08 13:50:30
|
Hi all, I would prefer: xterm -e vim Over: vim -gf For the default. Thanks, -Matt On Mon, Oct 08, 2012 at 11:18:17AM +0200, Hannes Schüller wrote: > Hi! > > Markus Demleitner <msd...@ar...> wrote: > > On Sun, Oct 07, 2012 at 08:04:05PM +0200, Hannes Schüller wrote: > > > Markus Demleitner <msd...@ar...> wrote: > > > > (talking about > > > > which: If I'd like to get this stuff into the upstream git, what > > > > would I do?) > > > > > > As announced on IRC last week, I'm planning to merge the mature > > > patches (like yours) in a week or so and make a new release. > > > > Ah -- are the requests in PATCHES still up-to-date, i.e., do you/does > > anyone want individual patches for the commits on the list? For the > > external editor, that's five patches (the first one is a huge mess of > > Hannes' initial changes and some additional hacking on it by yours > > truly, but the others are, I think, fairly reasonable) -- or should I > > push the stuff somewhere? Would you, Hannes, rather pull from > > somewhere? > > I would certainly appreciate if you could wrap the final patches up in > a canonical way again and send them to the list. The main reason being > that the first patch in this thread (the one "based on HEAD") seems to > be reversed. That would save us some back and forth history. > > Also, there seems to be a bit of a mixture between spaces and tabs > indentation in the patches. > > > Also, I've used the "goto error_exit" style in _resume_from_editor > > since I had to heavily edit the code anyway. Since I've not seen > > that anywhere else in vimprobable, I thought I'd ask whether anyone > > has large issues with this. I happen to believe this is usually > > preferable and more maintainable, but I'll change it to "local" > > resource management if someone doesn't agree. > > OK with me - anyone else? > > > Then, there should be some documentation on this, viz, > > > > * Key bindings: ^t opens an external editor > > * use "handler vimprobableedit <your editor> %s" to configure which > > external editor you'd like to use > > * the editor must open an X11 window and not fork from the parent; > > vim -gf does that, as does xterm -e vi > > > > I'm not quite sure where to put the last two points; > > The basic description should go in vimprobable2.1, I'd say, just like > the external URI handlers description. The handler setting (:set and rc > file) should go in vimprobablerc.5. > > > Finally, should there be a default on the vimprobableedit handler > > (vim -gf comes to mind)? If so, what would be a good place to set > > it? > > I would think launching regular vim in a terminal editor would suit > most users better, but please set me right, folks! > > Hannes > ------------------------------------------------------------------------------ > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > _______________________________________________ > Vimprobable-users mailing list > Vim...@li... > https://lists.sourceforge.net/lists/listinfo/vimprobable-users -- Matthew Carter je...@gm... |