Re: [Vimprobable-users] Editor patch evolution

[Markus D. <msd...@ar...>]

Hi,

On Sun, Oct 07, 2012 at 08:04:05PM +0200, Hannes Schüller wrote:
> Markus Demleitner <msd...@ar...> wrote:
> > (talking about
> > which: If I'd like to get this stuff into the upstream git, what
> > would I do?)
> 
> As announced on IRC last week, I'm planning to merge the mature patches
> (like yours) in a week or so and make a new release.

Ah -- are the requests in PATCHES still up-to-date, i.e., do you/does
anyone want individual patches for the commits on the list?  For the
external editor, that's five patches (the first one is a huge mess of
Hannes' initial changes and some additional hacking on it by yours
truly, but the others are, I think, fairly reasonable) -- or should I
push the stuff somewhere?  Would you, Hannes, rather pull from
somewhere?

Also, I've used the "goto error_exit" style in _resume_from_editor
since I had to heavily edit the code anyway.  Since I've not seen
that anywhere else in vimprobable, I thought I'd ask whether anyone
has large issues with this.  I happen to believe this is usually
preferable and more maintainable, but I'll change it to "local"
resource management if someone doesn't agree.

Then, there should be some documentation on this, viz,

* Key bindings: ^t opens an external editor
* use "handler vimprobableedit <your editor> %s" to configure which
  external editor you'd like to use
* the editor must open an X11 window and not fork from the parent;
  vim -gf does that, as does xterm -e vi

I'm not quite sure where to put the last two points; I'd appreciate
if someone else could add some appropriate prose to... erm...
whereever it belongs (the tempdir setting I've already mentioned in
vimprobablerc.5 -- is everyone fine with the name?).

Finally, should there be a default on the vimprobableedit handler
(vim -gf comes to mind)?  If so, what would be a good place to set
it?

Cheers,

         Markus