Re: [Vimprobable-users] Editor patch, revised

[Jason R. <jas...@gm...>]

On 27/09/12 at 10:55pm, Markus Demleitner wrote:
> Hi,
Hi Markus - thanks for the patch.
> 
> I've taken Hannes' patch for the external editor and changed it to
> emply the handler mechanism.  Basically, you say
> 
> handler vimprobableedit vim -gf %s
> 
> in your vimprobablerc, and when hitting ^t in a text field, you'll
> get a gvim window.
> 
I don't have gvim installed, so I used:
handler vimprobableedit urxvtc -e vim %s

and the term opens, I compose my message and then, when I exit the term,
the file exists in /tmp/vimprobableXXXX but nothing is printed to the
text field in vimprobable.

> This also fixes a bug in which the ":" protocol separator did not get
> stripped from the argument in open_handler (but frankly, that code is
> extremely spooky -- does anyone actually understand what all the temp
> magic is supposed to do?).
> 
> One "architectural" question: I'm potentially emitting quit a bit of
> diagnostics -- is give_feedback the right function for this?  Should
> I do something else yet?
> 
> If people are happy with the way this works, I'd go ahead and
> document it (plus probable bug fixing); I guess the vim -gf shold be
> a builtin default, shouldn't it?
> 
Wouldn't ${EDITOR:-vi} be more appropriate? Just a thought…
  
Cheers,

/J

-- 

http://jasonwryan.com/  [GnuPG Key: B1BD4E40]