[Vimprobable-users] [PATCH] New function echo_message()
Vimprobable is a lean web browser optimised for full keyboard control
Brought to you by:
hanness
From: Daniel C. <dan...@gm...> - 2012-09-07 12:54:25
|
Hi! The attached patch removes the give_feedback function by a new a litte more flexible echo_message function. The give_feedback function was nearly unused in the code. But I often found code like Arg a; a.i = Info; a.s = g_strdup_printf("Message %s", message); echo(&a); g_free(a.s); so I removed this code by a call to the new function too. This makes the code a little smaller and also the compiled binary (on my machine by 3% or 4066 bytes). I'm not sure if I forgot some calls to free, but the check with valgrind caused nearly the same output like the vimprobable version from current master, so I'm confident that the patch works. Comments are welcome! Daniel |