[Vimprobable-users] [PATCH 0/3] Refactor settings code and add possibility to show setting value

[Raphael N. <rne...@hs...>]

Hi there

I this patch series adds some changes to the browsersettings code. I think using a
single enum instead of three different booleans is much more intuitive.

To be able to use the give_feedback() function I needed to set focus to the
webview widget, otherwise it wouldn't show anything. I consider this a bug, since
it also doesn't show anything when entering an invalid setting.

The third patch saves the value for boolean settings into the .var field of the
setting. I need to do this as well for integer settings, but I wanted to
receive some feedback on the patch in general first. I also thought about using
something like:
struct {
	ESetingsType type;
	union value {
		char *s;
		int i;
		gboolean b;
	};
}
for the settings to not be forced to save every value as a string.

Raphael

Raphael Nestler (3):
  Use enum instead of booleans for setting type
  Show setting on set command without value
  Set setting values also for booleans

 config.h      | 80 +++++++++++++++++++++++++++++------------------------------
 main.c        | 23 +++++++++++------
 vimprobable.h | 11 +++++---
 3 Dateien geändert, 64 Zeilen hinzugefügt(+), 50 Zeilen entfernt(-)

-- 
1.7.11.2