|
From: Jason R. <jas...@gm...> - 2012-06-28 09:38:36
|
On 28/06/12 at 10:32am, Hannes Schüller wrote: > Jason Ryan <jas...@gm...> wrote: > > On 28/06/12 at 02:35am, Hans-Peter Deifel wrote: > > > On Mi, Jun 27 2012, Hannes Sch__ller wrote: > > > > the attached patch should finally make the browser handle > > > > window.open events correctly. Testing of different websites would > > > > be greatly appreciated. > > > > > > I haven't tested this much, but so far it seems to work. I have > > > published a git branch with the patch for easier testing: > > > > > > http://git.cs.fau.de/?p=lu03pevi/vimprobable;a=shortlog;h=refs/heads/fixes/javascript_windows > > > > > Thanks this works great. > > > > There is slightly aberrant behaviour when opening a link from within > > Google Reader (I know, no-one cares, but I wanted to mention it in > > case it pops up anywhere else): hitting 'v' opens the linked article > > in a new window and also opens duckduckgo (default search engine) > > with an 'about:blank' search. > > Who says no-one cares? Please show me an example (which I don't have to > sign up for). If I can reproduce it, I will try to fix this. Though, of > course, I'd rather have two windows opened than none ;) > I meant that as it was a Google-related site, I would not expect much interest from the Vimprobable community (and rightly so…) I've only seen it on that site and it does require a sign on; and yes, you are right, it works twice as well as it used to! /J -- http://jasonwryan.com/ [GnuPG Key: B1BD4E40] |
