Re: [Vimprobable-users] [PATCH 0/2] Vimprobable1 autohide inputbar when empty.

[<gre...@gm...>]

On Sun May 27 2012 04:40:14 AM CDT, Hannes Schüller <ha...@yl...> wrote:

> Hi,
> 
> sorry about the late reply.
> 
> Greg Lutostanski <gre...@gm...> wrote:
> > On Sun, May 06, 2012 at 04:01:22PM +0200, Hannes Sch??ller wrote:
> > > I find it strange that in your patch, you never actually check
> > > whether the inputbar is empty. Unless I'm misinterpreting
> > > something, you simply force it to always be empty by setting
> > > echo_active = false and then hide it.
> > 
> > Your right, I don't explicitly check as to whether the inputbar is
> > empty. Instead I am using the boolean echo_active to check if
> > something is in the inputbar that should be seen. Basically whenever
> > echo(* Arg) is used, it is set to show the inputbar and prevent
> > automatic clearing.
> 
> What if some function calls echo()? This has nothing to do with the
> state of echo_active, but nevertheless, it will populate the bar.

Well echo_active wasn't ever used in the codebase for vimprobable1 --except for one if statement, so I changed it so that echo_active switches on/off whenever echo() or clear_echo() is used. Patch 1/2 has all these changes, the second patch builds on top to do the hiding of the bar.

-- Greg