Re: [Vimprobable-users] [PATCH 0/2] Vimprobable1 autohide inputbar when empty.

[Greg L. <gre...@gm...>]

On Sun, May 06, 2012 at 04:01:22PM +0200, Hannes Sch??ller wrote:
> Hello Greg,
> 

Hi Hannes,

Thanks for taking a look at this. And as this is my first time
posting anything in this mailing list, let me say thanks for the work
you and everyone else here have done making a great program.

> I find it strange that in your patch, you never actually check whether
> the inputbar is empty. Unless I'm misinterpreting something, you simply
> force it to always be empty by setting echo_active = false and then
> hide it.
Your right, I don't explicitly check as to whether the inputbar is
empty. Instead I am using the boolean echo_active to check if something is
in the inputbar that should be seen. Basically whenever echo(* Arg) is
used, it is set to show the inputbar and prevent automatic clearing.

On the other hand when the inputbar has user input in it -- it pops up
and stays visbile as long as it is in line-edit mode. (When it is
activated [Enter] it goes away immediately.

> 
> Last year, I made a similar patch which you can still find in the
> archives here:
> http://sourceforge.net/mailarchive/forum.php?thread_name=20111209082411.GA15480%40ubuntu.dotsource.local&forum_name=vimprobable-users
> (for some reason the frontend claims the initial message, which
> includes the patch, is in HTML format; which it isn't). It had some
> issues, though (as pointed out by Daniel in the thread). Maybe this can
> give you some inspiration?
> 
> Hannes

I think I have made it so that whenever there is some text in the
inputbar -- no matter what it is, it is visible. The issues you refer to
are not apparent in this patchset.

Unfourtunately this is my first time submitting patches using git so the
way it split into two different patches makes the changes less apparent.

I have tested it pretty extensively and there are only two hiccups as
far as I can tell.
    1. When using the GTK_PROGRESS_BAR the inputbar goes away then pops
    back up to show the progress -- it hides/unhides fast.
    2. The inputbar starts shown -- which is in my opinion incorrect
    behavior.

Please note that the above hiccups are easily fixable with two small
changes -- I just notice them until after I sent this patchset in.

Thanks,
    Greg