Re: [Vimprobable-users] [PATCH 1/3] New command ':w[rite]' to save the current document

[Hans-Peter D. <hpd...@gm...>]

Hi,

Daniel Carl <dan...@gm...> writes:
> this is a feature I waited for a long time. But I found a small bug. If I save
> a page into a none existing path, vimprobable says 'Download
> file:///home/daniel/foo/foo.html finished' but the foo directory was not
> created and the file was not downloaded. I think we should test if the
> download was really done, if not echo a error message in vimprobable.

Well spotted! I think this is a bug in Webkit. We already check the
status of the download in download_process() and print the "finished"
message only if it is WEBKIT_DOWNLOAD_STATUS_FINISHED.

I also get strange messages like

  (vimprobable2:5547): GLib-GIO-CRITICAL **: g_output_stream_write_all:
  assertion `G_IS_OUTPUT_STREAM (stream)' failed

if I try to save a page to a nonexistent path.


We could work around this by calling access(2) before starting the
download. That's a little ugly, but I will prepare a new patch with it.

  HP