Re: [Vimprobable-users] [Patches] New hint modes

[Daniel C. <dan...@gm...>]

Hi!
On Sat, Oct 01, 2011 at 02:38:58PM +0200, Hannes Schüller wrote:
> diff --git a/hinting.js b/hinting.js
> index e23abc6..fb45b84 100644
> --- a/hinting.js
> +++ b/hinting.js
> @@ -262,6 +262,8 @@ function Hints() {
>          {
>              case "f": result = _open(el); break;
>              case "F": result = _openNewWindow(el); break;
> +            case "s": result = _save(el); break;
> +            case "y": case "O": result = _yank(el); break;
>              default:  result = _getElemtSource(el);
>          }

This is OK, but in my opinion it is better to read an less code if we use
something like

    case "f": result = _open(el); break;
    case "F": result = _openNewWindow(el); break;
    case "s": result = "save;" + _getElemtSource(el); break;
    case "y": result = "yank;" + _getElemtSource(el); break;
    case "O": result = "colon;" + _getElemtSource(el); break;
    default:  result = _getElemtSource(el);

To not implements for each action a new function.

Daniel