Re: [Vimprobable-users] [PATCH] Refactured hinting

[Daniel C. <dan...@gm...>]

Hi Hannes!

On Tue, Aug 23, 2011 at 11:01:36AM +0200, Hannes Schüller wrote:
> I've still got an offset of six lines
> in main.c when applying the patches (starting with patch 1) though. Are
> you sure you don't have any other changes in your branch? This didn't
> prevent me from applying the patches, but it might hint at some change
> being missed in the series.
I'm not sure. I got one warning about a whitespace clash during I made
the patchfiles. I don't want to post again such a large number of
patches. The branch on github should work - I've spent some time to
rollback the github repositorie's master branch to the vimprobable2
upstream HEAD and rebased all branches on it. If needed I can post it
here, but I promise it's nought there.

> - Since lowercase "f" now also respects a link's target attribute,
>   target="_blank" is handled as well. This conforms to the HTML
>   specification, I guess, but I somehow liked to be able to ignore this
>   nonsense of opening links in a new window. Opinions?
I agree that 'f' should force to load the link into the current window.
For links that have the target _blank set as real attribute we can
remove it before firering it - it would be easy to implement. But there
are a number of pages that simulate the setting of the target attribute
via an eventobserver or a JavaScript function to set the target on thy
fly. I disbelieve that we would be able to open these links into the
current window.

> - This logic relocation clashes with this URI handler patch:
>   http://www.vimprobable.org/mailman/archives/vimprobable-users/2011-June/000781.html .
>   Not necessarily a showstopper, needs to be kept in mind, though.
Thank you for the hint, I'll have a look at the patch and try to adapt
the hinting to work together with it.

Daniel