Re: [Vimprobable-users] [PATCH] Refactured hinting

[Hannes S. <ha...@yl...>]

Hi!

Daniel Carl <dan...@gm...> wrote:
> On Sat, Aug 20, 2011 at 08:03:47PM +0200, Hannes Schüller wrote:
> > after applying all patches in succession, hints don't appear in this
> > version at all anymore. Also, there is now a tremendous amount of
> > history in these patch series. I think it might be time to create a
> > new, clean patch series to begin systematic issue tracking?
> 
> I think I've startet refacturing on the wrong branch. Maybe this was
> the reason, that the patches didn't apply on top of eachother. I've
> rebased the branch to top of vimprobable2 and made all patches again.
> Hope they will work.

Thanks, this seems to work! I'm giving it a stress test right now, but
the first glance looks very good. I've still got an offset of six lines
in main.c when applying the patches (starting with patch 1) though. Are
you sure you don't have any other changes in your branch? This didn't
prevent me from applying the patches, but it might hint at some change
being missed in the series.

First impressions:
- Since lowercase "f" now also respects a link's target attribute,
  target="_blank" is handled as well. This conforms to the HTML
  specification, I guess, but I somehow liked to be able to ignore this
  nonsense of opening links in a new window. Opinions?
- This logic relocation clashes with this URI handler patch:
  http://www.vimprobable.org/mailman/archives/vimprobable-users/2011-June/000781.html .
  Not necessarily a showstopper, needs to be kept in mind, though.

Hannes