Re: [Vimprobable-users] [PATCH] Refactured hinting

[Hannes S. <ha...@yl...>]

Hi,

first review:

- The patches you posted don't apply cleanly on top of each other. This
  is due to whitespace breakage.

- Talking of whitespace breakage, the first patch seems to be
  especially messy in this regard. Some parts of the code are hardly
  readable after applying it.

- From a functional point of view, I like this very much! As you
  already said, we will probably have to find a way to preserve the
  target information (I see your point about relocating this logic
  into Javascript now). The way it is now is already very useful,
  though.

- Using the patch, I get the following message on the console: "@1:
  Unsafe JavaScript attempt to access frame with URL
  http://... from frame with URL http://... Domains, protocols and
  ports must match."

Hannes