Re: [Vimprobable-users] [PATCH] Refactured hinting

[Hannes S. <ha...@yl...>]

Hello Daniel,

without getting into the coding issues right now (that should be the
second step), let's talk about the behaviour/policy changes this patch
introduces first.

"Daniel Carl" <dan...@gm...> wrote:
> - Implemented removing of hints if a number is selected. That means
> that hint are removed that don't match a given number like in
> vimperator. I you type 1 in hintingmode all hint except of [1,10-19]
> will be removed. The hintnumber will not be updated and it's already
> possible to tab or shift- tab through the remaining hints.

I see some advantages of this behaviour, but also some potential
disadvantages. You did the right thing insofar that the hint numbers
don't change. It give the users better overview or confuse them due to
visual irritation (I'm undecided). It could be a problem that not all
hintable elements are clearly visible anymore if users want to correct
their selection. I'd like to hear more opinions.

> - Implemented possibility to fire focused hint by return key. I hope
> this feature will make other hintingfeteatures easier to implement

I'm not sure what the change is here. Return already fires the active
hint, doesn't it?

> I this we should made some decision where to handle the different to 
> implement hinting actions (open link, copy linktext to clipboard,
> focus hinted element). In my opinion this could be given via
> parameter to the js-function that generates the hints, so we can
> later if the hint is selected simply use fire() to handle the action.
> This should also keep the c-code cleaner.

I disagree. The way I envision it (and the way I implemented the other
hinting modes), the Javascript code is the universal part and the
different actions/targets are remembered and implemented in C. Already,
the idea is to simply use fire() - that passes the selected data back
to the C layer, nothing else. The C layer needs to know what action the
hints have been requested for anyway (since this is where the request
originates). I don't see any advantage in passing that information
which we already have at that level to an even higher one in order to
implement more logic there. But maybe I'm misunderstanding your point.

> I could not find the path for copy the hinted url to clipboard that
> was mentioned in a previous mail, i think i should it merke into the
> patch.

http://www.vimprobable.org/mailman/archives/vimprobable-users/2011-June/000797.html

Hannes